std: Stabilize the hash module#22480
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 19, 2015
Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
r? @aturon |
Member
Author
|
The diff stat is a bit alarming, but it's 99% due to |
fea7ad7 to
3143c4b
Compare
Contributor
There was a problem hiding this comment.
The doc comment above here is slightly stale -- some of it should move to the methods, I think.
Contributor
|
So... I don't know how to meaningfully review the 4+kloc of stage0 fallout here, but the changes to the core module LGTM. Let me know if there's any particular area of fallout that you think wants more scrutiny. |
This commit is an implementation of [RFC 823][rfc] which is another pass over the `std::hash` module for stabilization. The contents of the module were not entirely marked stable, but some portions which remained quite similar to the previous incarnation are now marked `#[stable]`. Specifically: [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0823-hash-simplification.md * `std::hash` is now stable (the name) * `Hash` is now stable * `Hash::hash` is now stable * `Hasher` is now stable * `SipHasher` is now stable * `SipHasher::new` and `new_with_keys` are now stable * `Hasher for SipHasher` is now stable * Many `Hash` implementations are now stable All other portions of the `hash` module remain `#[unstable]` as they are less commonly used and were recently redesigned. This commit is a breaking change due to the modifications to the `std::hash` API and more details can be found on the [RFC][rfc]. Closes rust-lang#22467 [breaking-change]
Contributor
|
@bors: r+ fbad3bf |
Contributor
|
@bors: p=1 (important stabilization to land pre-alpha2 if possible) |
Collaborator
|
⌛ Testing commit fbad3bf with merge c77b248... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Member
Author
This was referenced Feb 18, 2015
Collaborator
|
⌛ Testing commit f83e23a with merge 68ff044... |
Collaborator
|
💔 Test failed - auto-win-64-opt |
Collaborator
|
💔 Test failed - auto-win-32-nopt-t |
Collaborator
|
💔 Test failed - auto-win-32-opt |
Collaborator
|
💔 Test failed - auto-win-64-nopt-t |
Collaborator
|
💔 Test failed - auto-linux-64-nopt-t |
Member
Author
|
@bors: retry |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 19, 2015
This commit is an implementation of [RFC 823][rfc] which is another pass over the `std::hash` module for stabilization. The contents of the module were not entirely marked stable, but some portions which remained quite similar to the previous incarnation are now marked `#[stable]`. Specifically: [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0823-hash-simplification.md * `std::hash` is now stable (the name) * `Hash` is now stable * `Hash::hash` is now stable * `Hasher` is now stable * `SipHasher` is now stable * `SipHasher::new` and `new_with_keys` are now stable * `Hasher for SipHasher` is now stable * Many `Hash` implementations are now stable All other portions of the `hash` module remain `#[unstable]` as they are less commonly used and were recently redesigned. This commit is a breaking change due to the modifications to the `std::hash` API and more details can be found on the [RFC][rfc]. Closes rust-lang#22467 [breaking-change]
Collaborator
|
⌛ Testing commit f83e23a with merge fe7b8b2... |
Collaborator
|
💔 Test failed - auto-linux-32-opt |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
…excrichton This commit has already been merged in rust-lang#21774, but i think it has been accidently overriden by rust-lang#22584 and rust-lang#22480. r? @alexcrichton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is an implementation of RFC 823 which is another pass over
the
std::hashmodule for stabilization. The contents of the module were notentirely marked stable, but some portions which remained quite similar to the
previous incarnation are now marked
#[stable]. Specifically:std::hashis now stable (the name)Hashis now stableHash::hashis now stableHasheris now stableSipHasheris now stableSipHasher::newandnew_with_keysare now stableHasher for SipHasheris now stableHashimplementations are now stableAll other portions of the
hashmodule remain#[unstable]as they are lesscommonly used and were recently redesigned.
This commit is a breaking change due to the modifications to the
std::hashAPIand more details can be found on the RFC.
Closes #22467
[breaking-change]