Skip to content

change the signal used to test signal_reported_right#22404

Merged
huonw merged 1 commit into
rust-lang:masterfrom
semarie:signal_reported_right
Feb 18, 2015
Merged

change the signal used to test signal_reported_right#22404
huonw merged 1 commit into
rust-lang:masterfrom
semarie:signal_reported_right

Conversation

@semarie

@semarie semarie commented Feb 16, 2015

Copy link
Copy Markdown
Contributor

The test "signal_reported_right" send a signal 1 to /bin/sh, and check
the status code to check if the signal is reported right.

Under OpenBSD, the signal 1 (SIGHUP) is catched by /bin/sh,
resulting the test failed.

Use the uncatchable signal 9 (SIGKILL) for test.

The test "signal_reported_right" send a signal `1` to `/bin/sh`, and check
the status code to check if the signal is reported right.

Under OpenBSD, the signal `1` (`SIGHUP`) is catched by `/bin/sh`,
resulting the test failed.

Use the uncatchable signal `9` (`SIGKILL`) for test.
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon

aturon commented Feb 16, 2015

Copy link
Copy Markdown
Contributor

Thanks!

@bors: r+ 5a6ea7a

Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 17, 2015
…uron

 The test \"signal_reported_right\" send a signal `1` to `/bin/sh`, and check
the status code to check if the signal is reported right.

Under OpenBSD, the signal `1` (`SIGHUP`) is catched by `/bin/sh`,
resulting the test failed.

Use the uncatchable signal `9` (`SIGKILL`) for test.
@huonw huonw merged commit 5a6ea7a into rust-lang:master Feb 18, 2015
@semarie semarie deleted the signal_reported_right branch February 18, 2015 12:54
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants