Closed
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
I know nothing of LLVM, re-assigning to @alexcrichton |
Contributor
|
Seems a bit early to update that. We're using parts of LLVM that don't have a stable API, these might change between now and the time that 3.7 is actually released. So we shouldn't claim to be compatible with 3.7 just yet. I'd rather have that check only succeed for released LLVM versions. There could be a flag that skips the version check for those who want to build against LLVM trunk. Just my 2 cents. |
Contributor
Author
|
Yes, you are right. I was too optimistic, it fails with 3.7 atm. |
Member
dotdash
added a commit
to dotdash/rust
that referenced
this pull request
Feb 10, 2015
When trying to build against a newer, local LLVM version it might be preferable to have a flag to disable the LLVM version check instead of having to modify the configure script. Fixes rust-lang#21998
Member
|
Closing in favor of #22147, but thanks again for the PR! |
Contributor
Author
|
@dotdash: thanks for adding a flag. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 10, 2015
When trying to build against a newer, local LLVM version it might be preferable to have a flag to disable the LLVM version check instead of having to modify the configure script. Fixes rust-lang#21998 r? @alexcrichton
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
When trying to build against a newer, local LLVM version it might be preferable to have a flag to disable the LLVM version check instead of having to modify the configure script. Fixes rust-lang#21998 r? @alexcrichton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subj. Also, sould we change this check to something else? As it is a little bit annoying to fix it with every changing of LLVM version.