shell 'case' statement don't need 'break'#21643
Merged
bors merged 1 commit intorust-lang:masterfrom Jan 29, 2015
Merged
Conversation
the syntax of 'case' is: `case word in [[(] pattern [| pattern] ...) list ;; ] ... esac` `list` don't have to issue `break`. `break` is normally used to exit a `for`, `until` or `while` loop.
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Contributor
barosl
added a commit
to barosl/rust
that referenced
this pull request
Jan 27, 2015
the syntax of 'case' is: `case word in [[(] pattern [| pattern] ...) list ;; ] ... esac` `case` don't have to issue `break`. `break` is normally used to exit a `for`, `until` or `while` loop. `src/etc/local_stage0.sh` is used with `configure --enable-local-rust`, in order to copy local rust to stage0 directory. Without this patch, warning message is issued (under openbsd at least): `..../src/etc/local_stage0.sh[38]: break: cannot break` As this patch corrects a part of the build process, I can't add a regression test.
lnicola
added a commit
to lnicola/rust
that referenced
this pull request
Feb 16, 2026
…-generate-impl-to-use-astnodeedit migrate generate_impl assist to use AstNodeEdit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the syntax of 'case' is:
case word in [[(] pattern [| pattern] ...) list ;; ] ... esaccasedon't have to issuebreak.breakis normally used to exit afor,untilorwhileloop.src/etc/local_stage0.shis used withconfigure --enable-local-rust, in order to copy local rust to stage0 directory.Without this patch, warning message is issued (under openbsd at least):
..../src/etc/local_stage0.sh[38]: break: cannot breakAs this patch corrects a part of the build process, I can't add a regression test.