Skip to content

add split_off method to vec with tests#21608

Merged
bors merged 1 commit intorust-lang:masterfrom
JeffBelgum:collections-reform-issue-19986-add-append-and-split-off
Jan 28, 2015
Merged

add split_off method to vec with tests#21608
bors merged 1 commit intorust-lang:masterfrom
JeffBelgum:collections-reform-issue-19986-add-append-and-split-off

Conversation

@JeffBelgum
Copy link
Contributor

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

r? @gankro

@rust-highfive rust-highfive assigned Gankra and unassigned alexcrichton Jan 25, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit nervosd about this since this is accurate Rust notation, but confusing as math notation.

probably fine as is, though.

@JeffBelgum
Copy link
Contributor Author

@gankro I've made all the changes required by the comments, please review. I'll squash my commits down if it looks good.

@Gankra
Copy link
Contributor

Gankra commented Jan 26, 2015

r=me with assert message and squash

@JeffBelgum
Copy link
Contributor Author

I was going off the (lack of) message in slice.split_at

@JeffBelgum JeffBelgum force-pushed the collections-reform-issue-19986-add-append-and-split-off branch from 8696e9a to b93843e Compare January 26, 2015 22:09
@JeffBelgum
Copy link
Contributor Author

r? @gankro

@Gankra
Copy link
Contributor

Gankra commented Jan 26, 2015

@bors r+ b938 rollup

barosl added a commit to barosl/rust that referenced this pull request Jan 27, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 27, 2015
@bors bors merged commit b93843e into rust-lang:master Jan 28, 2015
lnicola pushed a commit to lnicola/rust that referenced this pull request Feb 16, 2026
fix: Fix `set_top_subtree_delimiter_span` using wrong index for close span
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants