Return the String guide to its former glory. by steveklabnik · Pull Request #21056 · rust-lang/rust

steveklabnik · 2015-01-12T22:36:14Z

When we moved over to the book, we lost this.

sfackler · 2015-01-12T22:37:08Z

src/doc/trpl/more-strings.md

"Like any Rust reference type" maybe?

agreed, fixe

nrc · 2015-01-12T22:45:51Z

r? @sfackler

steveklabnik · 2015-01-21T16:31:42Z

This has been updated now.

sfackler · 2015-01-21T17:05:47Z

src/doc/trpl/more-strings.md

Using &'static str here seems wrong, maybe "string literal"?

Why is it wrong?

It just seems a bit strange since the paragraph's saying that slices are a view into an already allocated string, such as a slice, but isn't that a view into an already allocated string?

I guess it is strange because it's an edge case: a &'static str is an always-allocated thing. And I tend to refer to things by their type explicitly. But I can see that. Lemme fix it.

sfackler · 2015-01-21T17:06:59Z

r=me with the one last nit.

steveklabnik · 2015-01-21T17:25:34Z

@bors: r=sfackler b33dfdb rollup

bors · 2015-01-22T16:13:33Z

⌛ Testing commit b33dfdb with merge 1fcaec0...

bors · 2015-01-22T16:50:16Z

💔 Test failed - auto-mac-64-opt

When we moved over to the book, we lost this.

steveklabnik · 2015-01-22T18:34:06Z

@bors: r=sfackler cef8295 rollup

steveklabnik · 2015-01-22T18:34:13Z

Woo notrust isn't a thing anymore.

…kler When we moved over to the book, we lost this.

- Successful merges: #21056, #21091, #21217, #21325, #21373, #21450, #21471, #21472, #21477, #21479, #21484, #21496, #21500, #21516, #21517 - Failed merges:

…yarn/editors/code/glob-11.1.0 Bump glob from 11.0.1 to 11.1.0 in /editors/code

sfackler reviewed Jan 12, 2015
View reviewed changes

nrc assigned sfackler Jan 12, 2015

steveklabnik force-pushed the return_strings branch from 5d74940 to e68865b Compare January 21, 2015 16:31

sfackler reviewed Jan 21, 2015
View reviewed changes

steveklabnik force-pushed the return_strings branch from e68865b to b33dfdb Compare January 21, 2015 17:25

steveklabnik force-pushed the return_strings branch from b33dfdb to cef8295 Compare January 22, 2015 18:33

Return the String guide to its former glory.

cef8295

When we moved over to the book, we lost this.

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 22, 2015

Rollup merge of rust-lang#21056 - steveklabnik:return_strings, r=sfac…

d1c7ae4

…kler When we moved over to the book, we lost this.

steveklabnik mentioned this pull request Jan 22, 2015

Rollup of 15 pull requests #21530

Merged

bors added a commit that referenced this pull request Jan 23, 2015

Auto merge of #21530 - steveklabnik:rollup, r=steveklabnik

4874ca3

- Successful merges: #21056, #21091, #21217, #21325, #21373, #21450, #21471, #21472, #21477, #21479, #21484, #21496, #21500, #21516, #21517 - Failed merges:

bors merged commit cef8295 into rust-lang:master Jan 23, 2015

lnicola pushed a commit to lnicola/rust that referenced this pull request Nov 19, 2025

Merge pull request rust-lang#21056 from rust-lang/dependabot/npm_and_…

216b26b

…yarn/editors/code/glob-11.1.0 Bump glob from 11.0.1 to 11.1.0 in /editors/code

Uh oh!

Conversation

steveklabnik commented Jan 12, 2015

Uh oh!

sfackler Jan 12, 2015

Choose a reason for hiding this comment

Uh oh!

steveklabnik Jan 21, 2015

Choose a reason for hiding this comment

Uh oh!

nrc commented Jan 12, 2015

Uh oh!

steveklabnik commented Jan 21, 2015

Uh oh!

sfackler Jan 21, 2015

Choose a reason for hiding this comment

Uh oh!

steveklabnik Jan 21, 2015

Choose a reason for hiding this comment

Uh oh!

sfackler Jan 21, 2015

Choose a reason for hiding this comment

Uh oh!

steveklabnik Jan 21, 2015

Choose a reason for hiding this comment

Uh oh!

sfackler commented Jan 21, 2015

Uh oh!

steveklabnik commented Jan 21, 2015

Uh oh!

bors commented Jan 22, 2015

Uh oh!

bors commented Jan 22, 2015

Uh oh!

steveklabnik commented Jan 22, 2015

Uh oh!

steveklabnik commented Jan 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants