Merged
Conversation
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
r? @aturon |
Member
Author
|
I should also point out that the entire |
Member
Author
|
cc #20475 a use case for another free function, but not sure if we want a huge array of free functions here. |
src/libcollections/string.rs
Outdated
Contributor
There was a problem hiding this comment.
I think we should offer this convenience in ffi, something like ffi::c_str_to_string.
Member
Author
There was a problem hiding this comment.
I'm somewhat worried about a large array of functions popping up in "view this C string as a rust type":
c_str_to_bytesx 2 for_with_nulc_str_to_bytes_with_max_size(e.g. CString should have a "within max length" constructor #20475) x 2 for_with_nulc_str_to_str
I think I'd be more in favor of sticking to the bare bones for now, and perhaps expanding later? After thinking a bit, I think that #20475 may be able to be handled by slice::from_raw_buf plus a search for 0, and the to_str variant may not actually come up all that often depending on the application. I suppose I'm always a fan of conservativeness, and we do tend to avoid providing too many convenience methods that are just compositions of some others.
Contributor
|
Looks great overall! I think |
5bd16eb to
5deef52
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 5, 2015
This commit is an implementation of [RFC 494][rfc] which removes the entire `std::c_vec` module and redesigns the `std::c_str` module as `std::ffi`. [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0494-c_str-and-c_vec-stability.md The interface of the new `CString` is outlined in the linked RFC, the primary changes being: * The `ToCStr` trait is gone, meaning the `with_c_str` and `to_c_str` methods are now gone. These two methods are replaced with a `CString::from_slice` method. * The `CString` type is now just a wrapper around `Vec<u8>` with a static guarantee that there is a trailing nul byte with no internal nul bytes. This means that `CString` now implements `Deref<Target = [c_char]>`, which is where it gains most of its methods from. A few helper methods are added to acquire a slice of `u8` instead of `c_char`, as well as including a slice with the trailing nul byte if necessary. * All usage of non-owned `CString` values is now done via two functions inside of `std::ffi`, called `c_str_to_bytes` and `c_str_to_bytes_with_nul`. These functions are now the one method used to convert a `*const c_char` to a Rust slice of `u8`. Many more details, including newly deprecated methods, can be found linked in the RFC. This is a: [breaking-change] Closes rust-lang#20444
This commit is an implementation of [RFC 494][rfc] which removes the entire `std::c_vec` module and redesigns the `std::c_str` module as `std::ffi`. [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0494-c_str-and-c_vec-stability.md The interface of the new `CString` is outlined in the linked RFC, the primary changes being: * The `ToCStr` trait is gone, meaning the `with_c_str` and `to_c_str` methods are now gone. These two methods are replaced with a `CString::from_slice` method. * The `CString` type is now just a wrapper around `Vec<u8>` with a static guarantee that there is a trailing nul byte with no internal nul bytes. This means that `CString` now implements `Deref<Target = [c_char]>`, which is where it gains most of its methods from. A few helper methods are added to acquire a slice of `u8` instead of `c_char`, as well as including a slice with the trailing nul byte if necessary. * All usage of non-owned `CString` values is now done via two functions inside of `std::ffi`, called `c_str_to_bytes` and `c_str_to_bytes_with_nul`. These functions are now the one method used to convert a `*const c_char` to a Rust slice of `u8`. Many more details, including newly deprecated methods, can be found linked in the RFC. This is a: [breaking-change] Closes rust-lang#20444
5deef52 to
ec7a50d
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 6, 2015
This commit is an implementation of [RFC 494][rfc] which removes the entire `std::c_vec` module and redesigns the `std::c_str` module as `std::ffi`. [rfc]: https://github.com/rust-lang/rfcs/blob/master/text/0494-c_str-and-c_vec-stability.md The interface of the new `CString` is outlined in the linked RFC, the primary changes being: * The `ToCStr` trait is gone, meaning the `with_c_str` and `to_c_str` methods are now gone. These two methods are replaced with a `CString::from_slice` method. * The `CString` type is now just a wrapper around `Vec<u8>` with a static guarantee that there is a trailing nul byte with no internal nul bytes. This means that `CString` now implements `Deref<Target = [c_char]>`, which is where it gains most of its methods from. A few helper methods are added to acquire a slice of `u8` instead of `c_char`, as well as including a slice with the trailing nul byte if necessary. * All usage of non-owned `CString` values is now done via two functions inside of `std::ffi`, called `c_str_to_bytes` and `c_str_to_bytes_with_nul`. These functions are now the one method used to convert a `*const c_char` to a Rust slice of `u8`. Many more details, including newly deprecated methods, can be found linked in the RFC. This is a: [breaking-change] Closes rust-lang#20444
zmbush
added a commit
to zmbush/git2-rs
that referenced
this pull request
Jan 10, 2015
Mostly fixing issues related to rust-lang/rust#20507 The examples still aren't compiling, but I figured this might be a good starting point for finishing the upgrade.
This was referenced Jan 19, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is an implementation of RFC 494 which removes the entire
std::c_vecmodule and redesigns thestd::c_strmodule asstd::ffi.The interface of the new
CStringis outlined in the linked RFC, the primarychanges being:
ToCStrtrait is gone, meaning thewith_c_strandto_c_strmethodsare now gone. These two methods are replaced with a
CString::from_slicemethod.
CStringtype is now just a wrapper aroundVec<u8>with a staticguarantee that there is a trailing nul byte with no internal nul bytes. This
means that
CStringnow implementsDeref<Target = [c_char]>, which is whereit gains most of its methods from. A few helper methods are added to acquire a
slice of
u8instead ofc_char, as well as including a slice with thetrailing nul byte if necessary.
CStringvalues is now done via two functions insideof
std::ffi, calledc_str_to_bytesandc_str_to_bytes_with_nul. Thesefunctions are now the one method used to convert a
*const c_charto a Rustslice of
u8.Many more details, including newly deprecated methods, can be found linked in
the RFC. This is a:
[breaking-change]
Closes #20444