removed struct_variant feature as it is not gated anymore#19014
Closed
Kintaro wants to merge 1 commit intorust-lang:masterfrom
Kintaro:master
Closed
removed struct_variant feature as it is not gated anymore#19014Kintaro wants to merge 1 commit intorust-lang:masterfrom Kintaro:master
Kintaro wants to merge 1 commit intorust-lang:masterfrom
Kintaro:master
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. |
Member
|
I don't think this will build. The stage0 compiler is still checking for the feature. |
Contributor
|
maybe a |
Contributor
Author
|
A right, forgot to switch to my repository for the test build. My bad. |
Member
Contributor
Author
|
Sorry, had some git issues. Will reopen it.Do I just create a new PR or how do I go about this? |
Member
|
We chatted on IRC, but posting here for posterity as well. Reopening should do the trick! |
Member
|
As in, a new PR :) |
bors
added a commit
that referenced
this pull request
Nov 22, 2014
The struct_variant is not gated anymore. This commit just removes it and the resulting warnings when compiling rust. Now compiles with the snapshot from 11/18 (as opposed to PR #19014)
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 27, 2025
Check cfg when collecting macro defs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The struct_variant is not gated anymore. This commit just removes it and the resulting warnings when compiling rust.