Skip to content

collections: Remove all collections traits#18474

Closed
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
alexcrichton:no-more-traits
Closed

collections: Remove all collections traits#18474
alexcrichton wants to merge 1 commit intorust-lang:masterfrom
alexcrichton:no-more-traits

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Oct 31, 2014

As part of the collections reform RFC, this commit removes all collections
traits in favor of inherent methods on collections themselves. All methods
should continue to be available on all collections.

This is a breaking change with all of the collections traits being removed and
no longer being in the prelude. In order to update old code you should move the
trait implementations to inherent implementations directly on the type itself.

Note that some traits had default methods which will also need to be implemented
to maintain backwards compatibility.

[breaking-change]
cc #18424

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 31, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@alexcrichton alexcrichton mentioned this pull request Oct 31, 2014
Closed
24 tasks
@Gankra
Copy link
Contributor

Gankra commented Oct 31, 2014

I'm building off this specualtively. Got this:

C:\users\alexis\documents\github\rust\src\libstd\rand\os.rs:133:9: 133:37 error: unresolved import `core_collections::Collection`. There is no `Collection` in `core_collections`
C:\users\alexis\documents\github\rust\src\libstd\rand\os.rs:133     use core_collections::Collection;
                                                                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
C:\users\alexis\documents\github\rust\src\libstd\dynamic_lib.rs:282:9: 282:32 error: unresolved import `collections::MutableSeq`. There is no `MutableSeq` in `collections`
C:\users\alexis\documents\github\rust\src\libstd\dynamic_lib.rs:282     use collections::MutableSeq;
                                                                            ^~~~~~~~~~~~~~~~~~~~~~~
C:\users\alexis\documents\github\rust\src\libstd\rt\backtrace.rs:660:9: 660:37 error: unresolved import `core_collections::Collection`. There is no `Collection` in `core_collections`
C:\users\alexis\documents\github\rust\src\libstd\rt\backtrace.rs:660     use core_collections::Collection;
                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
error: aborting due to 3 previous errors

@Gankra
Copy link
Contributor

Gankra commented Oct 31, 2014

@alexcrichton Ah, these are #[cfg(windows)] things. That explains why you missed 'em.

@alexcrichton
Copy link
Member Author

alexcrichton commented Oct 31, 2014

Thanks for the heads up @gankro! I've updated to hopefully compile on windows as well now

@Gankra
Copy link
Contributor

Gankra commented Oct 31, 2014

ack, and now you have merge conflicts. So many collection changes 😭

aturon
aturon reviewed Oct 31, 2014
View reviewed changes
src/libcollections/bench.rs Outdated
Copy link
Contributor

@aturon aturon Oct 31, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how this comment relates to the rest of the file.

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 31, 2014
@alexcrichton
rollup merge of rust-lang#18474 : alexcrichton/no-more-traits
bc4c65e 
Conflicts:
	src/libstd/path/mod.rs
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 31, 2014
@alexcrichton
rollup merge of rust-lang#18474 : alexcrichton/no-more-traits
9cc4745 
Conflicts:
	src/libstd/path/mod.rs
@sfackler
Copy link
Member

sfackler commented Nov 1, 2014

Needs a rebase

@Gankra
Copy link
Contributor

Gankra commented Nov 1, 2014

Look, @bors. I know you really like generic collection programming, but you've gotta let go. Just... come on. 😞

@alexcrichton
collections: Remove all collections traits
21ac985 
As part of the collections reform RFC, this commit removes all collections
traits in favor of inherent methods on collections themselves. All methods
should continue to be available on all collections.

This is a breaking change with all of the collections traits being removed and
no longer being in the prelude. In order to update old code you should move the
trait implementations to inherent implementations directly on the type itself.

Note that some traits had default methods which will also need to be implemented
to maintain backwards compatibility.

[breaking-change]
cc rust-lang#18424
michaelsproul added a commit to michaelsproul/rust-typemap that referenced this pull request Nov 1, 2014
@michaelsproul
Remove upstream collection traits.
a6c1e04 
As per rust-lang/rust#18474
michaelsproul added a commit to michaelsproul/rust-typemap that referenced this pull request Nov 1, 2014
@michaelsproul
(fix) Remove upstream collection traits.
12a41d5 
As per rust-lang/rust#18474
@michaelsproul michaelsproul mentioned this pull request Nov 1, 2014
Merged
michaelsproul added a commit to michaelsproul/rust-typemap that referenced this pull request Nov 1, 2014
@michaelsproul
(fix) Remove upstream collection traits.
10587f0 
As per rust-lang/rust#18474
bors added a commit that referenced this pull request Nov 1, 2014
@bors
auto merge of #18474 : alexcrichton/rust/no-more-traits, r=aturon
39f90ae 
As part of the collections reform RFC, this commit removes all collections
traits in favor of inherent methods on collections themselves. All methods
should continue to be available on all collections.

This is a breaking change with all of the collections traits being removed and
no longer being in the prelude. In order to update old code you should move the
trait implementations to inherent implementations directly on the type itself.

Note that some traits had default methods which will also need to be implemented
to maintain backwards compatibility.

[breaking-change]
cc #18424
@bors bors closed this Nov 1, 2014
@Gankra
Copy link
Contributor

Gankra commented Nov 1, 2014

Awesome! Building my patch now.

@tolgap tolgap mentioned this pull request Nov 7, 2014
Closed
@alexcrichton alexcrichton deleted the no-more-traits branch November 20, 2014 03:18
lnicola pushed a commit to lnicola/rust that referenced this pull request Dec 11, 2024
@Veykril
Merge pull request rust-lang#18474 from Veykril/push-nvtxykxkwnvs
b4dc94d 
Make bracket typing handler work on more things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexcrichton @rust-highfive @Gankra @sfackler @glacjay @aturon @bors