librustc: Add an intrinsic to retrieve the return pointer of a function.#16248
Closed
pcwalton wants to merge 1 commit intorust-lang:masterfrom
Closed
librustc: Add an intrinsic to retrieve the return pointer of a function.#16248pcwalton wants to merge 1 commit intorust-lang:masterfrom
pcwalton wants to merge 1 commit intorust-lang:masterfrom
Conversation
This is needed for some GC stuff in Servo.
1 task
Contributor
|
Pulled in as part of #16081. |
bors
added a commit
that referenced
this pull request
Jun 27, 2016
Remove the return_address intrinsic. This intrinsic to get the return pointer was introduced in #16248 / #16081 by @pcwalton for Servo. However, as explained in #34227, it's impossible to ensure it's used correctly, and it broke with `-Zorbit`. Servo's usage is being replaced in servo/servo#11872, and I expect nobody else to have abused it. But I've also started a crater run, just in case this is a `[breaking-change]` for anyone else.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
internal: Add proc-macro-test crate back to the main workspace Should fix rust-lang/rust-analyzer#16194
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 25, 2025
…ializers (rust-lang#16248) When the initializer is a function call or suffixed literal (e.g., `size_of::<T>()` or `10u8`), suggest casting the initializer too, since changing only the type annotation would fail to compile. Fixes rust-lang/rust-clippy#16240 ``` changelog: [`needless_type_cast`]: Fix suggesting invalid code for non-literal initializers ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for some GC stuff in Servo.
r? @alexcrichton