Remove skip_norm_w/i/p().def_id with a helper#158620
Merged
rust-bors[bot] merged 1 commit intoJul 1, 2026
Merged
Conversation
…nstantiate_identity().skip_norm_wip().def_id
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
Shourya742
commented
Jun 30, 2026
Comment on lines
+451
to
+455
| impl<I: Interner> EarlyBinder<I, ty::TraitRef<I>> { | ||
| pub fn def_id(&self) -> I::TraitId { | ||
| self.value.def_id | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
I added this only for EarlyBinder<TraitRef> because the only current skip_norm_wip().def_id
uses I found were for trait refs. I also did not find an existing trait for “contains a def_id”.
Should this stay narrow, or should I add a small trait so EarlyBinder<T> can expose def_id()
for any T that has one?
Contributor
There was a problem hiding this comment.
hmm, this does seem like a somewhat useful abstraction, trait HasDefId and then wrappers just impl fn def_id for all T: HasDefId 🤔
I think for now that's probably not worth it, esp as in the trait solver we use different ids depending on what we're dealing with.
You can try doing that for EarlyBinder, Binder, and Unevaluated and see how it looks, but don't know whether it will end up being useful
Member
Author
There was a problem hiding this comment.
I will give it a shot locally and see how it looks, and let you know.
Contributor
|
thanks @bors r+ rollup |
Contributor
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove wip from this PR's title when it is ready for review. |
Member
Author
This seems new!! let me change the title |
Member
Author
|
@lcnr might need your approval again. |
Contributor
|
@bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 1, 2026
…nder-def-id, r=lcnr Remove skip_norm_w/i/p().def_id with a helper part of rust-lang#155345 r? @lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 5 pull requests Successful merges: - #158169 (Fix debuginfo compression in bootstrap) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 1, 2026
…nder-def-id, r=lcnr Remove skip_norm_w/i/p().def_id with a helper part of rust-lang#155345 r? @lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 8 pull requests Successful merges: - #150075 (Implement clamp_to) - #158169 (Fix debuginfo compression in bootstrap) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 1, 2026
…nder-def-id, r=lcnr Remove skip_norm_w/i/p().def_id with a helper part of rust-lang#155345 r? @lcnr
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 8 pull requests Successful merges: - #150075 (Implement clamp_to) - #156716 (tests: fix: parallel frontend test failures: different alloc ids) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 1, 2026
…uwer Rollup of 8 pull requests Successful merges: - #158294 (Use .drectve for MSVC DLL exports) - #156716 (tests: fix: parallel frontend test failures: different alloc ids) - #158397 (delegation: support simplest output `Self` mapping) - #158613 (Fix getrandom fallback test on platforms with `panic=abort`) - #158620 (Remove skip_norm_w/i/p().def_id with a helper) - #158633 (Remove unnecessary `Clone` derives on resolver types) - #158634 (Add missing `needs_drop` check to `DroplessArena`.) - #158647 (Document `strip_circumfix` behavior on overlapping prefix and suffix.)
rust-timer
added a commit
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #155345
r? @lcnr