tests: modify s390x vector test to be robust to instruction scheduling#158306
Merged
Conversation
A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot label: +llvm-main |
Contributor
Author
|
If it helps, llvm/llvm-project#188823 is the corresponding LLVM change |
JohnTitor
approved these changes
Jun 27, 2026
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 27, 2026
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
Rollup of 5 pull requests Successful merges: - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 27, 2026
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 27, 2026
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
Rollup of 5 pull requests Successful merges: - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 27, 2026
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
Rollup of 6 pull requests Successful merges: - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs) - #158472 (Add regression test for unexpected pointer dereference issue)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 27, 2026
…itor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
This was referenced Jun 27, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
…uwer Rollup of 13 pull requests Successful merges: - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax) - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #158480 (add smoketest for std::net::hostname) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158290 (add crashtests [1/N]) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158313 (Move `check_target_feature` into the attribute parser) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs) - #158467 (Add proc macro for unused assignments and corresponding test) - #158472 (Add regression test for unexpected pointer dereference issue) - #158475 (Fix doc comment on get_debug_as_hex.) - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
…uwer Rollup of 13 pull requests Successful merges: - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax) - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #158480 (add smoketest for std::net::hostname) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158290 (add crashtests [1/N]) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158313 (Move `check_target_feature` into the attribute parser) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs) - #158467 (Add proc macro for unused assignments and corresponding test) - #158472 (Add regression test for unexpected pointer dereference issue) - #158475 (Fix doc comment on get_debug_as_hex.) - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
…uwer Rollup of 13 pull requests Successful merges: - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax) - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #158480 (add smoketest for std::net::hostname) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158290 (add crashtests [1/N]) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158313 (Move `check_target_feature` into the attribute parser) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs) - #158467 (Add proc macro for unused assignments and corresponding test) - #158472 (Add regression test for unexpected pointer dereference issue) - #158475 (Fix doc comment on get_debug_as_hex.) - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 27, 2026
…uwer Rollup of 13 pull requests Successful merges: - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax) - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - #158480 (add smoketest for std::net::hostname) - #157625 (Use infer tys for synthetic params when lowering const paths point to fns) - #158290 (add crashtests [1/N]) - #158306 (tests: modify s390x vector test to be robust to instruction scheduling) - #158313 (Move `check_target_feature` into the attribute parser) - #158431 (More lint cleanups) - #158452 (Add missing links in integer docs) - #158467 (Add proc macro for unused assignments and corresponding test) - #158472 (Add regression test for unexpected pointer dereference issue) - #158475 (Fix doc comment on get_debug_as_hex.) - #158476 (Fix doc comment on FormattingOptions::new().)
rust-timer
added a commit
that referenced
this pull request
Jun 27, 2026
Rollup merge of #158306 - durin42:llvm-23-s390x-vec, r=JohnTitor tests: modify s390x vector test to be robust to instruction scheduling A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering. By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jun 29, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#157871 ([rustdoc] Update `doc_cfg` hide/show syntax) - rust-lang/rust#158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book) - rust-lang/rust#158480 (add smoketest for std::net::hostname) - rust-lang/rust#157625 (Use infer tys for synthetic params when lowering const paths point to fns) - rust-lang/rust#158290 (add crashtests [1/N]) - rust-lang/rust#158306 (tests: modify s390x vector test to be robust to instruction scheduling) - rust-lang/rust#158313 (Move `check_target_feature` into the attribute parser) - rust-lang/rust#158431 (More lint cleanups) - rust-lang/rust#158452 (Add missing links in integer docs) - rust-lang/rust#158467 (Add proc macro for unused assignments and corresponding test) - rust-lang/rust#158472 (Add regression test for unexpected pointer dereference issue) - rust-lang/rust#158475 (Fix doc comment on get_debug_as_hex.) - rust-lang/rust#158476 (Fix doc comment on FormattingOptions::new().)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.
By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!