Skip to content

tests: modify s390x vector test to be robust to instruction scheduling#158306

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-s390x-vec
Jun 27, 2026
Merged

tests: modify s390x vector test to be robust to instruction scheduling#158306
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
durin42:llvm-23-s390x-vec

Conversation

@durin42

@durin42 durin42 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!

A recent LLVM change causes some changes here, if I'm understanding
correctly it allows some better latency reduction. From what I can tell,
this test doesn't care that only a single register is used, so we use
-DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed
some of the test lines. I'm happy to split them back out if that's bad
for some reason though!
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 23, 2026
@rustbot

rustbot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 22 candidates

@durin42

durin42 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot label: +llvm-main

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label Jun 23, 2026
@durin42

durin42 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

If it helps, llvm/llvm-project#188823 is the corresponding LLVM change

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b11a76b has been approved by JohnTitor

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 27, 2026
…itor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
Rollup of 5 pull requests

Successful merges:

 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 27, 2026
…itor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
Rollup of 4 pull requests

Successful merges:

 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 27, 2026
…itor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
Rollup of 5 pull requests

Successful merges:

 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 27, 2026
…itor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
Rollup of 6 pull requests

Successful merges:

 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158472 (Add regression test for unexpected pointer dereference issue)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 27, 2026
…itor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
rust-bors Bot pushed a commit that referenced this pull request Jun 27, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - #158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - #158480 (add smoketest for std::net::hostname)
 - #157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - #158290 (add crashtests [1/N])
 - #158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - #158313 (Move `check_target_feature` into the attribute parser)
 - #158431 (More lint cleanups)
 - #158452 (Add missing links in integer docs)
 - #158467 (Add proc macro for unused assignments and corresponding test)
 - #158472 (Add regression test for unexpected pointer dereference issue)
 - #158475 (Fix doc comment on get_debug_as_hex.)
 - #158476 (Fix doc comment on FormattingOptions::new().)
@rust-bors rust-bors Bot merged commit e2c515a into rust-lang:main Jun 27, 2026
13 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 27, 2026
rust-timer added a commit that referenced this pull request Jun 27, 2026
Rollup merge of #158306 - durin42:llvm-23-s390x-vec, r=JohnTitor

tests: modify s390x vector test to be robust to instruction scheduling

A recent LLVM change causes some changes here, if I'm understanding correctly it allows some better latency reduction. From what I can tell, this test doesn't care that only a single register is used, so we use -DAG instead of -NEXT to allow some instruction reordering.

By happy coincidence, the z10 and z13 code matches now, which collapsed some of the test lines. I'm happy to split them back out if that's bad for some reason though!
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jun 29, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - rust-lang/rust#157871 ([rustdoc] Update `doc_cfg` hide/show syntax)
 - rust-lang/rust#158234 (Cross-referencing tuple_trait tracking issue, source and the Unstable Book)
 - rust-lang/rust#158480 (add smoketest for std::net::hostname)
 - rust-lang/rust#157625 (Use infer tys for synthetic params when lowering const paths point to fns)
 - rust-lang/rust#158290 (add crashtests [1/N])
 - rust-lang/rust#158306 (tests: modify s390x vector test to be robust to instruction scheduling)
 - rust-lang/rust#158313 (Move `check_target_feature` into the attribute parser)
 - rust-lang/rust#158431 (More lint cleanups)
 - rust-lang/rust#158452 (Add missing links in integer docs)
 - rust-lang/rust#158467 (Add proc macro for unused assignments and corresponding test)
 - rust-lang/rust#158472 (Add regression test for unexpected pointer dereference issue)
 - rust-lang/rust#158475 (Fix doc comment on get_debug_as_hex.)
 - rust-lang/rust#158476 (Fix doc comment on FormattingOptions::new().)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants