Preserve track_caller for by-value dyn vtable shims#157967
Merged
rust-bors[bot] merged 1 commit intoJun 18, 2026
Merged
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @folkertdev (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
This makes sense, the previous behavior was really an ABI mismatch I think. Either way it's only observable with @bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 17, 2026
…ble-shim, r=folkertdev Preserve track_caller for by-value dyn vtable shims Fixes rust-lang#157964
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…uwer Rollup of 8 pull requests Successful merges: - #157788 (Accumulate multiple -Zsanitizer target modifiers) - #158012 (Stabilize `strip_circumfix`) - #157810 (Query the trait solver in slow path for `missing_debug_implementations`) - #157829 (tests: adapt two tests for LLVM 23 changes) - #157917 (Don't suggest adding `in` to a `for` loop that already has one) - #157967 (Preserve track_caller for by-value dyn vtable shims) - #158019 (delegation: add simple test for incremental compilation) - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 17, 2026
…uwer Rollup of 12 pull requests Successful merges: - #157788 (Accumulate multiple -Zsanitizer target modifiers) - #158012 (Stabilize `strip_circumfix`) - #157810 (Query the trait solver in slow path for `missing_debug_implementations`) - #157829 (tests: adapt two tests for LLVM 23 changes) - #157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - #157886 (Reject extra fields in MGCA struct const arguments) - #157917 (Don't suggest adding `in` to a `for` loop that already has one) - #157967 (Preserve track_caller for by-value dyn vtable shims) - #158019 (delegation: add simple test for incremental compilation) - #158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`) - #158029 (Rename `project-stable-mir` to `project-rustc-public`) - #158044 (Add more tests for parallel frontend issues)
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jun 18, 2026
…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#157788 (Accumulate multiple -Zsanitizer target modifiers) - rust-lang/rust#158012 (Stabilize `strip_circumfix`) - rust-lang/rust#157810 (Query the trait solver in slow path for `missing_debug_implementations`) - rust-lang/rust#157829 (tests: adapt two tests for LLVM 23 changes) - rust-lang/rust#157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - rust-lang/rust#157886 (Reject extra fields in MGCA struct const arguments) - rust-lang/rust#157917 (Don't suggest adding `in` to a `for` loop that already has one) - rust-lang/rust#157967 (Preserve track_caller for by-value dyn vtable shims) - rust-lang/rust#158019 (delegation: add simple test for incremental compilation) - rust-lang/rust#158023 (Move `UnusedDuplicate` diag struct to `rustc_attr_parsing`) - rust-lang/rust#158029 (Rename `project-stable-mir` to `project-rustc-public`) - rust-lang/rust#158044 (Add more tests for parallel frontend issues)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157964