rustc_public: make sure hidden fields have their accessors#157748
Merged
Conversation
Collaborator
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
celinval
approved these changes
Jun 15, 2026
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 16, 2026
Rollup of 6 pull requests Successful merges: - #157707 (Introduce `-Z lint-rust-version`) - #157748 (rustc_public: make sure hidden fields have their accessors) - #157831 (test `carryless_mul` codegen) - #157879 (bootstrap: fix inverted success check in PowerShell download fallback) - #157933 (Use constant for detecting thin pointer formatting) - #157934 (update AttributeTemplate docs)
rust-timer
added a commit
that referenced
this pull request
Jun 16, 2026
Rollup merge of #157748 - makai410:var-def-idx, r=celinval rustc_public: make sure hidden fields have their accessors Per [the discussion](https://rust-lang.zulipchat.com/#narrow/channel/320896-project-rustc-public/topic/Do.20we.20want.20DefId.20to.20be.20publicly.20visible.20in.20our.20def.20wrappers.3F/with/600656013), we should make sure hidden fields have their corresponding accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion, we should make sure hidden fields have their corresponding accessors.