Skip to content

Link LLVM dynamically on x86_64-apple#157557

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
sgasho:link_llvm_dynamically_on_x86_mac
Jun 9, 2026
Merged

Link LLVM dynamically on x86_64-apple#157557
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
sgasho:link_llvm_dynamically_on_x86_mac

Conversation

@sgasho

@sgasho sgasho commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

View all comments

Link LLVM dynamically on x86_64-apple just like we did for aarch64-apple-darwin

r? @ZuseZ4

@rustbot

rustbot commented Jun 7, 2026

Copy link
Copy Markdown
Collaborator

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 7, 2026
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 7, 2026
@ZuseZ4

ZuseZ4 commented Jun 7, 2026

Copy link
Copy Markdown
Member

@bors delegate
r=me with CI green

@rust-bors

rust-bors Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

✌️ @sgasho, you can now approve this pull request!

If @ZuseZ4 told you to "r=me" after making some further change, then please make that change and post @bors r=ZuseZ4.

View changes since this delegation.

@sgasho

sgasho commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=ZuseZ4 rollup=never

@rust-bors

rust-bors Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c98c808 has been approved by ZuseZ4

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@bors try dist-x86_64-apple

@rust-bors

rust-bors Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Unknown argument "dist-x86_64-apple". Did you mean to use @bors jobs=<jobs>|parent=<parent>? Run @bors help to see available commands.

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@bors try jobs=dist-x86_64-apple

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026
Link LLVM dynamically on x86_64-apple


try-job: dist-x86_64-apple
@rust-bors

rust-bors Bot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 054df5a (054df5ab116eb068d603e015343feb5def797110, parent: 61d7280f3c4c63fa24c56bdaa9a446151b5a30dc)

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 8, 2026
…seZ4

Link LLVM dynamically on x86_64-apple

Link LLVM dynamically on x86_64-apple just like we did for aarch64-apple-darwin
* #157205

r? @ZuseZ4
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 8, 2026
@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c82119e failed: CI. Failed job:

@ZuseZ4

ZuseZ4 commented Jun 8, 2026

Copy link
Copy Markdown
Member

That error looks like nothing I've seen before. But also it has nothing to do with macos, so spurious

 ERROR: failed to build: failed to solve: ubuntu:26.04: failed to resolve source metadata for docker.io/library/ubuntu:26.04: failed to do request: Head "https://registry-1.docker.io/v2/library/ubuntu/manifests/26.04": dial tcp 18.215.123.132:443: i/o timeout
  Command failed. Attempt 5/5:
  #0 building with "vigorous_bouman" instance using docker-container driver
  
  #1 [internal] load build definition from Dockerfile
  #1 transferring dockerfile: 1.80kB done
  #1 DONE 0.0s
  
  #2 [internal] load metadata for docker.io/library/ubuntu:26.04
  #2 ERROR: failed to do request: Head "https://registry-1.docker.io/v2/library/ubuntu/manifests/26.04": dial tcp 100.50.204.84:443: i/o timeout

@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c98c808 has been approved by ZuseZ4

It is now in the queue for this repository.

A failed build status on this PR was cleared due to the approval.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 8, 2026
@rust-bors

rust-bors Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1960243 (1960243a5c34200335690ee6bc118224e8e88a7b, parent: 029c9e18dd1f4668e1d42bb187c1c263dfe20093)

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
…seZ4

Link LLVM dynamically on x86_64-apple



Link LLVM dynamically on x86_64-apple just like we did for aarch64-apple-darwin
* #157205

r? @ZuseZ4
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job dist-x86_64-illumos failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2026
@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 21890f3 failed: CI. Failed job:

@ZuseZ4

ZuseZ4 commented Jun 9, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c98c808 has been approved by ZuseZ4

It is now in the queue for this repository.

A failed build status on this PR was cleared due to the approval.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jun 9, 2026
…seZ4

Link LLVM dynamically on x86_64-apple



Link LLVM dynamically on x86_64-apple just like we did for aarch64-apple-darwin
* #157205

r? @ZuseZ4
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2026
@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0b19f23 failed: CI. Failed job:

@jhpratt

jhpratt commented Jun 9, 2026

Copy link
Copy Markdown
Member

spurious

@bors retry

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2026
@rust-bors

rust-bors Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: ZuseZ4
Duration: 3h 24m 47s
Pushing 057ed8b to main...

@rust-bors rust-bors Bot merged commit 057ed8b into rust-lang:main Jun 9, 2026
14 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a962594 (parent) -> 057ed8b (this PR)

Test differences

Show 4 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: pass -> ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) (J0)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 057ed8ba87418a77d5758f2d5e13f84b89b197e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-gcc-core-tests: 9m 35s -> 20m 54s (+117.8%)
  2. pr-check-1: 27m 29s -> 43m 9s (+57.1%)
  3. dist-apple-various: 1h 18m -> 1h 53m (+43.3%)
  4. x86_64-gnu-stable: 2h 21m -> 3h 16m (+38.3%)
  5. x86_64-gnu-tools: 57m 30s -> 1h 16m (+33.7%)
  6. dist-x86_64-solaris: 1h 16m -> 1h 38m (+29.5%)
  7. x86_64-gnu: 2h 22m -> 3h 4m (+29.4%)
  8. pr-check-2: 42m 34s -> 54m 41s (+28.5%)
  9. x86_64-rust-for-linux: 51m 14s -> 1h 4m (+26.5%)
  10. aarch64-apple: 3h 47m -> 2h 55m (-22.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (057ed8b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -6.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-6.5% [-6.5%, -6.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -6.5% [-6.5%, -6.5%] 1

Cycles

Results (secondary 4.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.0% [4.0%, 4.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 516.416s -> 517.542s (0.22%)
Artifact size: 401.26 MiB -> 400.80 MiB (-0.11%)

amandasystems pushed a commit to amandasystems/rust that referenced this pull request Jun 9, 2026
…mac, r=ZuseZ4

Link LLVM dynamically on x86_64-apple

Link LLVM dynamically on x86_64-apple just like we did for aarch64-apple-darwin
* rust-lang#157205

r? @ZuseZ4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants