Move derive tests into their dedicated folder by danieljofficial · Pull Request #157527 · rust-lang/rust

danieljofficial · 2026-06-06T09:28:38Z

Hi, I've moved some derive tests into their dedicated folder. Part of #133895
@zedddie
r? @Teapot4195

rustbot · 2026-06-06T09:28:41Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

rustbot · 2026-06-06T09:28:42Z

Failed to set assignee to Teapot4195: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

zedddie · 2026-06-06T09:36:05Z

r? Kivooeo

Kivooeo · 2026-06-06T10:09:32Z

@danieljofficial Thank you very much for all the work and time you’ve put into this project.

But I strongly encourage the two of you to get in touch with each other to sort out who is responsible for which tests and which parts of them; the current approach may be hindering @zedddie’s work.

Therefore, I would ask that, for the time being, please do not create any new pull requests until this matter has been resolved.

Thank you for your attention.

danieljofficial · 2026-06-06T10:33:09Z

And I was already working on another batch :(
As much as I don't see how working on an open issue can be "hindering", I do apologize if I caused @zedddie any trouble.
I'm sure we will be able to work something out.

zedddie · 2026-06-06T10:33:43Z

heyy @danieljofficial! could you DM me or write on the GSoC project stream on zulip, so we could split up areas we're working on to avoid overlaps?

UPD: we've agreed on approach that works for both of us.

Kivooeo · 2026-06-06T14:17:30Z

Good, thanks you both for cooperating!

Going to review this tomorrow

Kivooeo · 2026-06-09T00:30:25Z

sugg: not array field but compound types

View changes since the review

Alright, will make the change

Kivooeo · 2026-06-09T00:31:43Z

sugg: derive-compound-arities

View changes since the review

Kivooeo · 2026-06-09T00:34:25Z

q: this test checks that we can't use non-clone type inside struct that claims to be clone, which is not possible in rust because it requires to all fields to be clone

so i'm quite unsure about this name

View changes since the review

The issue was fixated on tuples, I wrongly assumed it was tied to the cause of the error. The test has evolved past the original intention. How does derived-trait-requires-field-impl sound ?

Kivooeo · 2026-06-18T14:36:18Z

@rustbot author

rustbot · 2026-06-18T14:36:22Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-06-18T16:29:53Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

danieljofficial · 2026-06-23T08:18:16Z

@Kivooeo What more needs to be done?

Kivooeo · 2026-06-23T11:36:03Z

next time ping rustbot ready, so i will see this

@bors r+ rollup

rust-bors · 2026-06-23T11:36:06Z

📌 Commit 68f9f5a has been approved by Kivooeo

It is now in the queue for this repository.

@zedddie

…, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of rust-lang#133895 @zedddie r? @Teapot4195

@zedddie

…, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of rust-lang#133895 @zedddie r? @Teapot4195

…uwer Rollup of 23 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158263 (Only load the feature list once in the entire resolver) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)

@zedddie

…, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of rust-lang#133895 @zedddie r? @Teapot4195

Rollup of 27 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158257 ( fix escaping placeholder check in next solver normalization folder) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) Failed merges: - #158256 (Avoid parser panics bubbling out to proc macros)

@zedddie

…, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of rust-lang#133895 @zedddie r? @Teapot4195

Rollup of 35 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #158336 (Stop excluding `stdarch` test crates from `rust-src`) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157419 (move rustc_type_ir Term things to term_kind.rs) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #157939 (Reorganize `tests/ui/issues` [8/N]) - #157946 (Make `char::is_private_use` and `char::is_assigned` unstably public) - #158003 (Reorganize `tests/ui/issues` [9/N]) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158060 (Reorganize `tests/ui/issues` [10/N]) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158272 (Reorganize `tests/ui/issues` [13/N]) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) - #158314 (Fix incorrect unsafe debug assertion in unchecked_div_exact) - #158326 (Add `io::ErrorKind::TooManyOpenFiles`)

@zedddie

…, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of rust-lang#133895 @zedddie r? @Teapot4195

Rollup of 35 pull requests Successful merges: - #158315 (`rust-analyzer` subtree update) - #158336 (Stop excluding `stdarch` test crates from `rust-src`) - #155739 (Add temporary scope to assert_eq and assert_ne) - #156885 (Fix misattributed type inference error span for index expressions) - #157271 (simplify some `proc_macro` things) - #157419 (move rustc_type_ir Term things to term_kind.rs) - #157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - #157921 (trait solver: Resolve region vars in max universe) - #157960 (delegation: add support for infers in generics) - #157983 (Lift the same-signature restriction for `extern "tail"`) - #158053 (Optimize network address parser) - #158105 (Extract all instance shim variants into new `ShimKind` enum) - #158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - #158279 (Follow goto and drop when linting unreachable code) - #157527 (Move derive tests into their dedicated folder) - #157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - #157939 (Reorganize `tests/ui/issues` [8/N]) - #157946 (Make `char::is_private_use` and `char::is_assigned` unstably public) - #158003 (Reorganize `tests/ui/issues` [9/N]) - #158020 (Update mingw-w64 C toolchain) - #158039 (c-variadic: test that we use equality up to free lifetimes) - #158060 (Reorganize `tests/ui/issues` [10/N]) - #158222 (format: ignore println newline in foreign format hints) - #158223 (Move target checking for #[lang] to the attribute parser) - #158252 (Use `cfg_select` in `std::os`) - #158263 (Only load the feature list once in the entire resolver) - #158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - #158272 (Reorganize `tests/ui/issues` [13/N]) - #158274 (triagebot: Stop pinging myself) - #158282 (slice_split_once: bounds check optimization note) - #158300 (Improve unknown crate_type diagnostic suggestions) - #158304 (mailmap: update mu001999) - #158309 (Update `rustc-literal-escaper` version to `0.0.8`) - #158314 (Fix incorrect unsafe debug assertion in unchecked_div_exact) - #158326 (Add `io::ErrorKind::TooManyOpenFiles`)

@zedddie

Rollup merge of #157527 - danieljofficial:move-tests-derives, r=Kivooeo Move derive tests into their dedicated folder Hi, I've moved some derive tests into their dedicated folder. Part of #133895 @zedddie r? @Teapot4195

Rollup of 35 pull requests Successful merges: - rust-lang/rust#158315 (`rust-analyzer` subtree update) - rust-lang/rust#158336 (Stop excluding `stdarch` test crates from `rust-src`) - rust-lang/rust#155739 (Add temporary scope to assert_eq and assert_ne) - rust-lang/rust#156885 (Fix misattributed type inference error span for index expressions) - rust-lang/rust#157271 (simplify some `proc_macro` things) - rust-lang/rust#157419 (move rustc_type_ir Term things to term_kind.rs) - rust-lang/rust#157883 (Remove strict invariant node_type on hir_type during ty privacy visit) - rust-lang/rust#157921 (trait solver: Resolve region vars in max universe) - rust-lang/rust#157960 (delegation: add support for infers in generics) - rust-lang/rust#157983 (Lift the same-signature restriction for `extern "tail"`) - rust-lang/rust#158053 (Optimize network address parser) - rust-lang/rust#158105 (Extract all instance shim variants into new `ShimKind` enum) - rust-lang/rust#158207 (Resolver: local/external split of `resolve_ident_in_module_non_globs_unadjusted` ) - rust-lang/rust#158279 (Follow goto and drop when linting unreachable code) - rust-lang/rust#157527 (Move derive tests into their dedicated folder) - rust-lang/rust#157807 (don't ice on non-lifetime binders under `-Zassumptions-on-binders`) - rust-lang/rust#157939 (Reorganize `tests/ui/issues` [8/N]) - rust-lang/rust#157946 (Make `char::is_private_use` and `char::is_assigned` unstably public) - rust-lang/rust#158003 (Reorganize `tests/ui/issues` [9/N]) - rust-lang/rust#158020 (Update mingw-w64 C toolchain) - rust-lang/rust#158039 (c-variadic: test that we use equality up to free lifetimes) - rust-lang/rust#158060 (Reorganize `tests/ui/issues` [10/N]) - rust-lang/rust#158222 (format: ignore println newline in foreign format hints) - rust-lang/rust#158223 (Move target checking for #[lang] to the attribute parser) - rust-lang/rust#158252 (Use `cfg_select` in `std::os`) - rust-lang/rust#158263 (Only load the feature list once in the entire resolver) - rust-lang/rust#158267 (FromUtf8Error::into_utf8_lossy better example and suggest use) - rust-lang/rust#158272 (Reorganize `tests/ui/issues` [13/N]) - rust-lang/rust#158274 (triagebot: Stop pinging myself) - rust-lang/rust#158282 (slice_split_once: bounds check optimization note) - rust-lang/rust#158300 (Improve unknown crate_type diagnostic suggestions) - rust-lang/rust#158304 (mailmap: update mu001999) - rust-lang/rust#158309 (Update `rustc-literal-escaper` version to `0.0.8`) - rust-lang/rust#158314 (Fix incorrect unsafe debug assertion in unchecked_div_exact) - rust-lang/rust#158326 (Add `io::ErrorKind::TooManyOpenFiles`)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2026

rustbot assigned Kivooeo Jun 6, 2026

Kivooeo reviewed Jun 9, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2026

Move derive tests out of tests/ui/issues

b1403bc

danieljofficial force-pushed the move-tests-derives branch from 5a303d7 to 3548970 Compare June 18, 2026 16:29

This comment has been minimized.

Sign in to view

add issue links and bless

68f9f5a

danieljofficial force-pushed the move-tests-derives branch from 3548970 to 68f9f5a Compare June 18, 2026 17:54

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 23, 2026

JonathanBrouwer mentioned this pull request Jun 23, 2026

Rollup of 23 pull requests #158316

Closed

JonathanBrouwer mentioned this pull request Jun 23, 2026

Rollup of 23 pull requests #158324

Closed

jhpratt mentioned this pull request Jun 24, 2026

Rollup of 27 pull requests #158335

Closed

This was referenced Jun 24, 2026

Rollup of 34 pull requests #158337

Closed

Rollup of 35 pull requests #158342

Merged

JonathanBrouwer mentioned this pull request Jun 24, 2026

[CI] Rollup of 35 pull requests #158354

Closed

rust-bors Bot merged commit dce284d into rust-lang:main Jun 25, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 25, 2026

Uh oh!

Uh oh!

Conversation

danieljofficial commented Jun 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 6, 2026

Uh oh!

rustbot commented Jun 6, 2026

Uh oh!

zedddie commented Jun 6, 2026

Uh oh!

Kivooeo commented Jun 6, 2026

Uh oh!

danieljofficial commented Jun 6, 2026

Uh oh!

zedddie commented Jun 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Jun 6, 2026

Uh oh!

Uh oh!

Kivooeo Jun 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danieljofficial Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jun 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danieljofficial Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Kivooeo Jun 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danieljofficial Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Jun 18, 2026

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

rustbot commented Jun 18, 2026

Uh oh!

This comment has been minimized.

danieljofficial commented Jun 23, 2026

Uh oh!

Kivooeo commented Jun 23, 2026

Uh oh!

rust-bors Bot commented Jun 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

danieljofficial commented Jun 6, 2026 •

edited by rustbot

Loading

zedddie commented Jun 6, 2026 •

edited

Loading

Kivooeo Jun 9, 2026 •

edited by rustbot

Loading

Kivooeo Jun 9, 2026 •

edited by rustbot

Loading

Kivooeo Jun 9, 2026 •

edited by rustbot

Loading