rustc_target: callconv: powerpc64: Remove unreachable fallback code path by Gelbpunkt · Pull Request #157459 · rust-lang/rust

Gelbpunkt · 2026-06-05T02:13:54Z

This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code.

Alternatively we could use cfg_abi in this code and match on ElfV1 / ElfV2 / VecExtAbi, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback.

r? @RalfJung

rustbot · 2026-06-05T02:13:59Z

RalfJung is not on the review rotation at the moment.
They may take a while to respond.

This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code.

rust-log-analyzer · 2026-06-09T23:59:15Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[TIMING:end] compile::StdLink { compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: [], force_recompile: false } -- 0.002
##[group]Building stage1 compiler artifacts (stage0 -> stage1, x86_64-unknown-linux-gnu)
error: process didn't exit successfully: `sccache /checkout/obj/build/bootstrap/debug/rustc -vV` (exit status: 2)
--- stderr
sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information

Bootstrap failed while executing `build --stage 2 compiler rustdoc`
Build completed unsuccessfully in 0:00:36
  local time: Tue Jun  9 23:59:01 UTC 2026
  network time: Tue, 09 Jun 2026 23:59:01 GMT

Gelbpunkt · 2026-06-10T00:13:27Z

that CI failure looks... unrelated and spurious

RalfJung · 2026-06-11T07:20:48Z

Thanks, nice cleanup!
@bors r+ rollup

rust-bors · 2026-06-11T07:20:51Z

📌 Commit a657539 has been approved by RalfJung

It is now in the queue for this repository.

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

…uwer Rollup of 23 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #152852 (Remove driver_lint_caps) - #155299 (make repr_transparent_non_zst_fields a hard error) - #155439 (Enable Cargo's new build-dir layout) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

@RalfJung

…-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

…uwer Rollup of 23 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #155299 (make repr_transparent_non_zst_fields a hard error) - #155439 (Enable Cargo's new build-dir layout) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

Rollup of 24 pull requests Successful merges: - #157716 (update Enzyme, June'26) - #149793 (Add inline asm support for amdgpu) - #155299 (make repr_transparent_non_zst_fields a hard error) - #157612 (Add a test where subtyping inhibits coercion.) - #157626 (Autogenerate unstable compiler flag stubs for unstable-book) - #157667 (Rename typing modes to better describe real usage) - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data) - #155113 (Ensure Send/Sync impl for std::process::CommandArgs) - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - #157342 (Reduce verbosity of cycle errors when possible) - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - #157698 (Remove an unnecessary cloning) - #157699 (Arg splat experiment - hir FnDecl impl) - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - #157722 (Move create_scope_map to rustc_codegen_ssa.) - #157723 (Move uninhabited unreachable code lint to rustc_mir_transform) - #157725 (Keep generic suggestion for macro-expanded missing-type items) - #157733 (Remove old FIXMEs about nocapture attribute) - #157737 (Reorganize `tests/ui/issues` [7/N]) - #157746 (supports_c_variadic_definitions: extend checklist for new targets) - #157763 (Move unused target expression error to appropriate place and rename it) - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

@RalfJung

Rollup merge of #157459 - Gelbpunkt:callconv-powerpc64-unset-abi-unreachable, r=RalfJung rustc_target: callconv: powerpc64: Remove unreachable fallback code path This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code. --- Alternatively we could use `cfg_abi` in this code and match on `ElfV1` / `ElfV2` / `VecExtAbi`, but... AIX remains a mystery to me and it would boil down to the same 3 branches and an unreachable fallback. r? @RalfJung

Rollup of 24 pull requests Successful merges: - rust-lang/rust#157716 (update Enzyme, June'26) - rust-lang/rust#149793 (Add inline asm support for amdgpu) - rust-lang/rust#155299 (make repr_transparent_non_zst_fields a hard error) - rust-lang/rust#157612 (Add a test where subtyping inhibits coercion.) - rust-lang/rust#157626 (Autogenerate unstable compiler flag stubs for unstable-book) - rust-lang/rust#157667 (Rename typing modes to better describe real usage) - rust-lang/rust#149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data) - rust-lang/rust#155113 (Ensure Send/Sync impl for std::process::CommandArgs) - rust-lang/rust#156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`) - rust-lang/rust#157342 (Reduce verbosity of cycle errors when possible) - rust-lang/rust#157366 (Add a regression test for an unconstrained TransmuteFrom ICE) - rust-lang/rust#157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path) - rust-lang/rust#157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy) - rust-lang/rust#157698 (Remove an unnecessary cloning) - rust-lang/rust#157699 (Arg splat experiment - hir FnDecl impl) - rust-lang/rust#157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`) - rust-lang/rust#157722 (Move create_scope_map to rustc_codegen_ssa.) - rust-lang/rust#157723 (Move uninhabited unreachable code lint to rustc_mir_transform) - rust-lang/rust#157725 (Keep generic suggestion for macro-expanded missing-type items) - rust-lang/rust#157733 (Remove old FIXMEs about nocapture attribute) - rust-lang/rust#157737 (Reorganize `tests/ui/issues` [7/N]) - rust-lang/rust#157746 (supports_c_variadic_definitions: extend checklist for new targets) - rust-lang/rust#157763 (Move unused target expression error to appropriate place and rename it) - rust-lang/rust#157768 (codegen_ssa: peel trans. wrappers on scalable vecs)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 5, 2026

rustbot assigned RalfJung Jun 5, 2026

Gelbpunkt force-pushed the callconv-powerpc64-unset-abi-unreachable branch from cf576f9 to 5c15e08 Compare June 5, 2026 02:28

RalfJung reviewed Jun 5, 2026

View reviewed changes

Comment thread compiler/rustc_target/src/callconv/powerpc64.rs Outdated

rustc_target: callconv: powerpc64: Remove unreachable fallback code path

a657539

This is effectively dead code now that we validate the target spec, so let's mark it as unreachable to avoid misleading people looking at this code.

Gelbpunkt force-pushed the callconv-powerpc64-unset-abi-unreachable branch from 5c15e08 to a657539 Compare June 9, 2026 23:55

Gelbpunkt requested a review from RalfJung June 9, 2026 23:57

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2026

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 13 pull requests #157759

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 13 pull requests #157761

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 12 pull requests #157765

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 16 pull requests #157775

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 23 pull requests #157784

Closed

JonathanBrouwer mentioned this pull request Jun 11, 2026

Rollup of 23 pull requests #157790

Closed

jhpratt mentioned this pull request Jun 12, 2026

Rollup of 24 pull requests #157794

Merged

rust-bors Bot merged commit 91cff1a into rust-lang:main Jun 12, 2026
2 of 12 checks passed

rustbot added this to the 1.98.0 milestone Jun 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rustc_target: callconv: powerpc64: Remove unreachable fallback code path#157459

rustc_target: callconv: powerpc64: Remove unreachable fallback code path#157459
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Gelbpunkt:callconv-powerpc64-unset-abi-unreachable

Gelbpunkt commented Jun 5, 2026 •

edited

Loading

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

Uh oh!

rust-log-analyzer commented Jun 9, 2026

Uh oh!

Gelbpunkt commented Jun 10, 2026

Uh oh!

RalfJung commented Jun 11, 2026

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Gelbpunkt commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 5, 2026

Uh oh!

Uh oh!

rust-log-analyzer commented Jun 9, 2026

Uh oh!

Gelbpunkt commented Jun 10, 2026

Uh oh!

RalfJung commented Jun 11, 2026

Uh oh!

rust-bors Bot commented Jun 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Gelbpunkt commented Jun 5, 2026 •

edited

Loading