remove `IsTypeConst` from `hir::TraitItemKind` by josetorrs · Pull Request #157330 · rust-lang/rust

josetorrs · 2026-06-02T20:05:36Z

rustbot · 2026-06-02T20:05:41Z

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

josetorrs · 2026-06-02T20:09:12Z

    // FIXME(mgca) eventually want to move the option that is around `ConstItemRhs<'hir>`
-    // into `ConstItemRhs`, much like `ast::ConstItemRhsKind`, but for now mark whether
-    // this node is a TypeConst with a flag.
+    // into `ConstItemRhs`, much like `ast::ConstItemRhsKind`


I think resolving the FIXME deserves it's own issue, would like to give it a try if there's an appetite for it

View changes since the review

I expect we probably actually have no reason to do this FIXME anymore now that we can get type-constness from the defid

should we remove this FIXME all together then?

yeah that seems reasonable

removed the fixme, also squashed the commits while I was at it

rustbot · 2026-06-03T09:25:47Z

The Clippy subtree was changed

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

RalfJung · 2026-06-03T17:40:01Z

                this.check_target_os(
                    &[Os::Linux, Os::Android, Os::FreeBsd, Os::MacOs, Os::Illumos],
                    link_name,
                )?;


Did you accidentally re-format this file...?
Please avoid format-only changes.

View changes since the review

yeah my bad, reverted in 29a658c

BoxyUwU · 2026-06-07T21:32:26Z

can you put Fixes #issue in the description so that merging this closes the associated issue? thanks :3

@bors try @rust-timer queue

remove `IsTypeConst` from `hir::TraitItemKind`

rust-bors · 2026-06-07T23:45:49Z

☀️ Try build successful (CI)
Build commit: de700f1 (de700f1a1abf34db2c53c62f6d07cea6fda5e7d2, parent: 43a4909ee98ed4d006d9d773f5d94dc58e34f846)

rust-timer · 2026-06-08T00:27:12Z

Finished benchmarking commit (de700f1): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.1%	[2.1%, 2.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.1%	[2.1%, 2.1%]	1

Cycles

Results (secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.4%	[2.7%, 4.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 516.093s -> 515.618s (-0.09%)
Artifact size: 400.83 MiB -> 400.83 MiB (-0.00%)

josetorrs · 2026-06-08T16:29:04Z

can you put Fixes #issue in the description so that merging this closes the associated issue?

updated

rustbot · 2026-06-10T02:44:46Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

BoxyUwU · 2026-06-10T19:52:33Z

@bors r+ rollup

rust-bors · 2026-06-10T19:52:36Z

📌 Commit 0b4a6f8 has been approved by BoxyUwU

It is now in the queue for this repository.

@BoxyUwU

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

@BoxyUwU

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

@BoxyUwU

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

@BoxyUwU

…BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes rust-lang#152940 following up on rust-lang#152940 (comment) r? @BoxyUwU

Rollup of 31 pull requests Successful merges: - #141030 (Expand free alias types during variance computation) - #154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - #155527 (Replace printables table with `unicode_data.rs` tables) - #156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - #157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - #157282 (Fix post-monomorphization error note race in the parallel frontend) - #157352 (Make the retained dep graph deterministic under the parallel frontend) - #157601 (Emit error for unused target expression in glob and list delegations) - #157611 (Update `browser-ui-test` version to `0.24.0`) - #157620 (Add a strategy FnMut to inject behavior into the flush cycle) - #157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - #157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - #157647 (Start using comptime for reflection intrinsics and their wrapper functions) - #157719 (resolve: Partially revert "Remove a special case for dummy imports") - #155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - #155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - #155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - #156497 (fix-155516: Don't suggest wrong unwrap expect) - #156583 (Support defaults for static EIIs) - #157013 (Ensure inferred let pattern types are well-formed) - #157196 (Only suggest reborrowing a moved value where the reborrow is valid) - #157230 (borrowck: avoid ICE describing fields on generic params) - #157288 (platform support: add SNaN erratum to MIPS targets) - #157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - #157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - #157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - #157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - #157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - #157691 (Move symbol hiding code to a new file) - #157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - #157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - #157699 (Arg splat experiment - hir FnDecl impl)

@BoxyUwU

Rollup merge of #157330 - josetorrs:remove-is-type-const, r=BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes #152940 following up on #152940 (comment) r? @BoxyUwU

Rollup of 31 pull requests Successful merges: - rust-lang#141030 (Expand free alias types during variance computation) - rust-lang#154853 (mgca: Register `ConstArgHasType` when normalizing projection consts) - rust-lang#155527 (Replace printables table with `unicode_data.rs` tables) - rust-lang#156629 (Stabilize `core::range::{legacy, RangeFull, RangeTo}`) - rust-lang#157280 (traits: Allow escaping self types in ExistentialTraitRef::with_self_ty) - rust-lang#157282 (Fix post-monomorphization error note race in the parallel frontend) - rust-lang#157352 (Make the retained dep graph deterministic under the parallel frontend) - rust-lang#157601 (Emit error for unused target expression in glob and list delegations) - rust-lang#157611 (Update `browser-ui-test` version to `0.24.0`) - rust-lang#157620 (Add a strategy FnMut to inject behavior into the flush cycle) - rust-lang#157645 (Windows TLS - Only register the `atexit` hook when `cleanup` can be unloaded) - rust-lang#157646 (Keep rename-imported main alive in dead-code analysis under `--test`) - rust-lang#157647 (Start using comptime for reflection intrinsics and their wrapper functions) - rust-lang#157719 (resolve: Partially revert "Remove a special case for dummy imports") - rust-lang#155153 (Ensure Send/Sync is not implemented for std::env::Vars{,Os}) - rust-lang#155198 (fix(mgca): Allow specifying generic args (of enum) on enum itself in unit & tuple variant constructions in (direct) const args) - rust-lang#155323 (refactor `TypeRelativePath::AssocItem` to use `AliasTerm`) - rust-lang#156497 (fix-155516: Don't suggest wrong unwrap expect) - rust-lang#156583 (Support defaults for static EIIs) - rust-lang#157013 (Ensure inferred let pattern types are well-formed) - rust-lang#157196 (Only suggest reborrowing a moved value where the reborrow is valid) - rust-lang#157230 (borrowck: avoid ICE describing fields on generic params) - rust-lang#157288 (platform support: add SNaN erratum to MIPS targets) - rust-lang#157330 (remove `IsTypeConst` from `hir::TraitItemKind`) - rust-lang#157350 (compiletest: ignore SVG `y` offset in by-lines comparison) - rust-lang#157355 (Add `or_try_*` variants for `HashMap` and `BTreeMap` Entry APIs) - rust-lang#157577 (Fix parser error recovery treating 'dyn' as a strict keyword in Rust 2015 when used in `dyn + dyn`) - rust-lang#157670 (Rename `errors.rs` file to `diagnostics.rs` (4/N)) - rust-lang#157691 (Move symbol hiding code to a new file) - rust-lang#157700 (Rename `errors.rs` file to `diagnostics.rs` (5/N)) - rust-lang#157703 (Fix doc link to Instant sub in saturating caveat) Failed merges: - rust-lang#157699 (Arg splat experiment - hir FnDecl impl)

rustbot assigned BoxyUwU Jun 2, 2026

josetorrs commented Jun 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the T-clippy Relevant to the Clippy team. label Jun 2, 2026

josetorrs marked this pull request as ready for review June 3, 2026 09:25

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 3, 2026

RalfJung reviewed Jun 3, 2026

View reviewed changes

BoxyUwU approved these changes Jun 7, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 7, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 7, 2026

Auto merge of #157330 - josetorrs:remove-is-type-const, r=<try>

de700f1

remove `IsTypeConst` from `hir::TraitItemKind`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 8, 2026

Remove unused is_type_const from hir::TraitItemKind

0b4a6f8

josetorrs force-pushed the remove-is-type-const branch from 8d295cf to 0b4a6f8 Compare June 10, 2026 02:44

rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 10, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2026

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 28 pull requests #157735

Closed

jhpratt mentioned this pull request Jun 11, 2026

Rollup of 31 pull requests #157739

Merged

rust-bors Bot merged commit 71f484e into rust-lang:main Jun 11, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone Jun 11, 2026

rust-timer added a commit that referenced this pull request Jun 11, 2026

Unrolled build for #157330

4f841cf

Rollup merge of #157330 - josetorrs:remove-is-type-const, r=BoxyUwU remove `IsTypeConst` from `hir::TraitItemKind` Fixes #152940 following up on #152940 (comment) r? @BoxyUwU

Uh oh!

Conversation

josetorrs commented Jun 2, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 2, 2026

Uh oh!

josetorrs Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Jun 3, 2026

Uh oh!

RalfJung Jun 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BoxyUwU commented Jun 7, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jun 7, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jun 8, 2026

Overall result: no relevant changes - no action needed

Uh oh!

josetorrs commented Jun 8, 2026

Uh oh!

rustbot commented Jun 10, 2026

Uh oh!

BoxyUwU commented Jun 10, 2026

Uh oh!

rust-bors Bot commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

josetorrs commented Jun 2, 2026 •

edited by rustbot

Loading

josetorrs Jun 2, 2026 •

edited

Loading

RalfJung Jun 3, 2026 •

edited by rustbot

Loading