Disallow importing from types when reexport is involved#15733
Closed
sanxiyn wants to merge 1 commit intorust-lang:masterfrom
Closed
Disallow importing from types when reexport is involved#15733sanxiyn wants to merge 1 commit intorust-lang:masterfrom
sanxiyn wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
|
Does this fix #15528 too - after this lands, it should be impossible to trigger that bug? |
Contributor
Author
|
Yes, it should be impossible to trigger that bug using the provided testcase. I am not sure in general though. |
bors
added a commit
that referenced
this pull request
Jul 18, 2014
Importing from types was disallowed in #6462. Flag was set for paths whether it is a module or a type. Type flag was set when impl was seen. The problem is, for cross-crate situations, when reexport is involved, it is possible that impl is seen too late because metadata is loaded lazily. Fix #15664.
Contributor
|
I can confirm that #15528 has been fixed by this. |
flip1995
added a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2025
r? @ghost changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing from types was disallowed in #6462. Flag was set for paths whether it is a module or a type. Type flag was set when impl was seen. The problem is, for cross-crate situations, when reexport is involved, it is possible that impl is seen too late because metadata is loaded lazily.
Fix #15664.