Relax test requirements for consistency#157300
Merged
rust-bors[bot] merged 1 commit intoJun 8, 2026
Merged
Conversation
petrochenkov
reviewed
Jun 3, 2026
Contributor
|
r=me with #157300 (comment) addressed (and commits squashed). |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
bdc23a4 to
1fc09be
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@rustbot ready |
Contributor
|
@bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
…uwer Rollup of 13 pull requests Successful merges: - #147302 (asm! support for the Xtensa architecture) - #148820 (Add very basic "comptime" fn implementation) - #157299 (Fix unstable diagnostics in tests) - #143511 (Improve TLS codegen by marking the panic/init path as cold) - #154608 (Add `_value` API for number literals in proc-macro) - #156762 (xfs support in `test_rename_directory_to_non_empty_directory`) - #157300 (Relax test requirements for consistency) - #157383 (tests: codegen-llvm: Ignore BPF targets in c-variadic-opt) - #157413 (fix: don't suggest .into_iter() for .cloned()/.copied() on non-reference Option) - #157578 (Fix diagnostics for non-exhaustive destructuring assignments (#157553)) - #157587 (explain that the size_of constant also serves to avoid optimizing away 'unused' size_of calls) - #157596 (test: remove ineffective link-extern-crate-with-drop-type test) - #157602 (rustdoc: Remove unnecessary fast path)
rust-timer
added a commit
that referenced
this pull request
Jun 8, 2026
Rollup merge of #157300 - zetanumbers:fix-note-on-different-line-tests, r=petrochenkov Relax test requirements for consistency That note occurring under the first emitted warning. Test `tests/ui/lint/rfc-2383-lint-reason/force_warn_expected_lints_fulfilled.rs` fails for parallel frontend due to its inconsistent order of diagnostics, which is fine on its own. As such this PR removes these note requirements and they are now only covered by `force_warn_expected_lints_fulfilled.stderr`, which is almost the same thing. Updates #154314 r? @nnethercote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That note occurring under the first emitted warning. Test
tests/ui/lint/rfc-2383-lint-reason/force_warn_expected_lints_fulfilled.rsfails for parallel frontend due to its inconsistent order of diagnostics, which is fine on its own. As such this PR removes these note requirements and they are now only covered byforce_warn_expected_lints_fulfilled.stderr, which is almost the same thing.Updates #154314
r? @nnethercote