Guide: improve error handling#15690
Closed
steveklabnik wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Closed
Contributor
Contributor
Author
|
Fixed! |
Contributor
Author
|
Double checked that everything passes. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
vscode: Fix line and col regexp for `rustc` problem matcher
When building the Rust compiler with `./x check` from within VS Code, the current `rustc` problem matcher thinks that the output from that command that looks like this:
Build completed successfully in 0:00:26
is about a problem in a file named `0` on line 00, col 26. This wouldn't be so bad if it wasn't for that VS Code tends to get stuck on this problem because of problems with opening the file '0'.
The rust compiler will never output problems with a line or a column that starts with 0, so change the regexp to require lines and cols to begin with `[1-9]` to fix this problem.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 18, 2025
The feature freeze period is over. changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was sort of awkward that we glossed over errors, and it was also awkward that we had to gloss over references and methods. I fixed the second by just implementing
cmpmyself, and significantly improved the section onunwrap(), I think.@huonw, what do you think?