Suppress garbled suggestions from strict provenance lints in macros#156861
Merged
rust-bors[bot] merged 1 commit intoMay 25, 2026
Merged
Conversation
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
46ace1f to
2afd8d3
Compare
mu001999
requested changes
May 24, 2026
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
0e706a1 to
13fae85
Compare
mu001999
reviewed
May 24, 2026
13fae85 to
ccac0d9
Compare
Contributor
Author
|
@rustbot ready |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 25, 2026
…stions, r=mu001999 Suppress garbled suggestions from strict provenance lints in macros The strict provenance lints (`lossy_provenance_casts`, `fuzzy_provenance_casts`) build suggestions using span arithmetic (`shrink_to_lo()`, `shrink_to_hi()`, `.to()`). When the cast sits inside a macro, those span operations produce broken output like `$e as ).addr()` because the spans don't map cleanly back to source text. The fix wraps suggestion fields in `Option` and checks `can_be_used_for_suggestions()` before constructing them. The lint itself still fires, you just don't get the garbled suggestion. Same approach already used in `op.rs` and `static_mut_refs.rs` in this crate. ### What changed - `errors.rs`: `sugg` fields in `LossyProvenanceInt2Ptr` and `LossyProvenancePtr2Int` are now `Option<...>` - `cast.rs`: suggestion construction in both `lossy_provenance_ptr2int_lint` and `fuzzy_provenance_int2ptr_lint` is guarded behind `can_be_used_for_suggestions()` - New regression test confirms both lints fire on casts inside macros, with no suggestion block in output Fixes #156850
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
💔 Test for 04f346b failed: CI. Failed job:
|
Member
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5b686bc (parent) -> 783eb8c (this PR) Test differencesShow 4 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 783eb8c8682ddde0807c60ed8293670ef523794f --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
Finished benchmarking commit (783eb8c): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary -4.4%, secondary -7.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -1.8%, secondary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 509.684s -> 511.327s (0.32%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The strict provenance lints (
lossy_provenance_casts,fuzzy_provenance_casts) build suggestions using span arithmetic (shrink_to_lo(),shrink_to_hi(),.to()). When the cast sits inside a macro, those span operations produce broken output like$e as ).addr()because the spans don't map cleanly back to source text.The fix wraps suggestion fields in
Optionand checkscan_be_used_for_suggestions()before constructing them. The lint itself still fires, you just don't get the garbled suggestion. Same approach already used inop.rsandstatic_mut_refs.rsin this crate.What changed
errors.rs:suggfields inLossyProvenanceInt2PtrandLossyProvenancePtr2Intare nowOption<...>cast.rs: suggestion construction in bothlossy_provenance_ptr2int_lintandfuzzy_provenance_int2ptr_lintis guarded behindcan_be_used_for_suggestions()Fixes #156850