Skip to content

tests: extend remap-path-prefix-std to all stdlib rlibs#156570

Open
paradoxicalguy wants to merge 1 commit into
rust-lang:mainfrom
paradoxicalguy:test-extend-rmake-clean
Open

tests: extend remap-path-prefix-std to all stdlib rlibs#156570
paradoxicalguy wants to merge 1 commit into
rust-lang:mainfrom
paradoxicalguy:test-extend-rmake-clean

Conversation

@paradoxicalguy

@paradoxicalguy paradoxicalguy commented May 14, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

problem:

the current remap-path-prefix-std run-make test validates path remapping for libstd.rlib, which leaves the rest of the distributed stdlib artifacts unchecked.

fix:

generalizing the test to go over over all distributed .rlib files found in the target sysroot libdir instead of checking only the libstd.

result:

improves reproducibility coverage for distributed stdlib artifacts.

r? @Urgau

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
Urgau
Urgau reviewed May 14, 2026
View reviewed changes
Comment thread tests/run-make/remap-path-prefix-std/rmake.rs
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from 4c83da0 to 6a3fc8b Compare May 14, 2026 13:28
@Urgau

Urgau commented May 14, 2026

Copy link
Copy Markdown
Member

@bors try jobs=dist-x86_64-linux

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 14, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
8d33ecc 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-x86_64-linux
@rust-bors

rust-bors Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8d33ecc (8d33ecc7330a13730e8a40214401163109712e5d, parent: 1a70f8d36e818b45829a5c065fd6004c9047e8d1)

@Urgau

Urgau commented May 14, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6a3fc8b has been approved by Urgau

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request May 14, 2026
@JonathanBrouwer
Rollup merge of rust-lang#156570 - paradoxicalguy:test-extend-rmake-c…
ba7e579 
…lean, r=Urgau

tests: extend remap-path-prefix-std to all stdlib rlibs

### problem:
the current `remap-path-prefix-std` run-make test validates path remapping for `libstd.rlib`, which leaves the rest of the distributed `stdlib` artifacts unchecked.

### fix:
generalizing the test to go over over all distributed `.rlib` files found in the target `sysroot libdir` instead of checking only the `libstd`.

### result:
improves reproducibility coverage for distributed `stdlib` artifacts.

r? @Urgau
@JonathanBrouwer JonathanBrouwer mentioned this pull request May 14, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request May 14, 2026
@bors
Auto merge of #156584 - JonathanBrouwer:rollup-R7ZHoDX, r=JonathanBro…
6b506f0 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #156452 (Implement pinned drop sugar)
 - #156571 (Disable `main_needs_argc_argv` for Wasm)
 - #156565 (delegation: emit error when self type is not specified and accessed)
 - #156570 (tests: extend remap-path-prefix-std to all stdlib rlibs)
@JonathanBrouwer

JonathanBrouwer commented May 15, 2026

Copy link
Copy Markdown
Contributor

@bors r-
#156584 (comment)

@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2026
@rust-bors

rust-bors Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#156584), which was unapproved.

View changes since this unapproval

Urgau
Urgau reviewed May 15, 2026
View reviewed changes
Comment thread tests/run-make/remap-path-prefix-std/rmake.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from 94d97b7 to afa7f77 Compare May 15, 2026 09:29
@Urgau

Urgau commented May 15, 2026

Copy link
Copy Markdown
Member

Let's do a quick try run to be sure.

@bors try jobs=dist-i586-gnu-i586-i686-musl

rust-bors Bot pushed a commit that referenced this pull request May 15, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
e47907c 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-i686-musl
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

💔 Test for e47907c failed: CI. Failed job:

@rust-bors

rust-bors Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

💔 Test for d53ab21 failed: CI. Failed job:

@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from ebc189d to 9fc1096 Compare May 23, 2026 13:05
@paradoxicalguy

paradoxicalguy commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-i586-gnu-i586-686-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 23, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
36405a0 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-686-musl
@rust-bors

rust-bors Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 36405a0 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@paradoxicalguy

paradoxicalguy commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 23, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
c3863a6 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-i686-musl
@rust-bors

rust-bors Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

💔 Test for c3863a6 failed: CI. Failed job:

@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from 9fc1096 to ee4fd55 Compare May 23, 2026 14:44
@paradoxicalguy

paradoxicalguy commented May 23, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request May 23, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
33da0d6 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-i686-musl
@rust-bors

rust-bors Bot commented May 23, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 33da0d6 failed: CI. Failed job:

@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from ee4fd55 to f4b347e Compare June 2, 2026 11:40
@paradoxicalguy

paradoxicalguy commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
ba24f83 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-i686-musl
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

💔 Test for ba24f83 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@paradoxicalguy paradoxicalguy force-pushed the test-extend-rmake-clean branch from f4b347e to d5bda62 Compare June 2, 2026 13:25
@paradoxicalguy

paradoxicalguy commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=dist-i586-gnu-i586-i686-musl

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jun 2, 2026
@bors
Auto merge of #156570 - paradoxicalguy:test-extend-rmake-clean, r=<try>
0d53b83 
tests: extend remap-path-prefix-std to all stdlib rlibs


try-job: dist-i586-gnu-i586-i686-musl
@rust-log-analyzer

rust-log-analyzer commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors

rust-bors Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 0d53b83 failed: CI. Failed job:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau approved these changes

Assignees

@Urgau Urgau

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paradoxicalguy @rust-log-analyzer @Urgau @JonathanBrouwer @rustbot