Implement OsStr::split_at#156444
Merged
Merged
Conversation
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
031fb5a to
6b16cde
Compare
This comment has been minimized.
This comment has been minimized.
6b16cde to
8477d3e
Compare
This comment has been minimized.
This comment has been minimized.
8477d3e to
85b7c96
Compare
nia-e
requested changes
May 12, 2026
| /// A valid `OsStr` boundary is one of: | ||
| /// - The start of the string | ||
| /// - The end of the string | ||
| /// - Immediately before a valid non-empty UTF-8 substring |
Member
There was a problem hiding this comment.
Should we also document that splitting is possible if the substrings aren't valid as long as the bytes at the split are (the test at tests.rs#347)?
Member
Author
There was a problem hiding this comment.
Hm, that was what I was trying to get across by talking about "before" and "after" mid. But I can try to rephrase it. Something like:
Suggested change
| /// - Immediately before a valid non-empty UTF-8 substring | |
| /// - the start of a valid non-empty UTF-8 substring | |
| /// - immediately follows a valid non-empty UTF-8 substring |
| /// The argument, `mid`, should be a valid byte offset from the start of the string. | ||
| /// It must also be on a valid `OsStr` boundary. | ||
| /// The method returns `None` if that’s not the case. | ||
| /// A valid `OsStr` boundary is one of: |
Member
There was a problem hiding this comment.
I'd rather we point to the docs of split_at or vice-versa, so these don't risk being out of sync
Member
|
r=me if nothing more comes up |
6c9cee5 to
921b35b
Compare
Member
Author
|
@bors r=nia-e |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 18, 2026
Implement `OsStr::split_at` See rust-lang#156199 This allows splitting only on valid UTF-8 boundaries, regardless of the platform, which avoids cross-platform landmines.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 18, 2026
…uwer Rollup of 13 pull requests Successful merges: - #156709 (stdarch subtree update) - #155006 (stabilize `feature(cfg_target_has_atomic_equal_alignment)`) - #156444 (Implement `OsStr::split_at`) - #156582 (Allow `global_asm!` in statement positions) - #156661 (Remove `UncheckedIterator`) - #152367 (Derives `Copy` for `ffi::FromBytesUntilNulError`) - #156443 (Fix invalid suggestion for parenthesized break) - #156606 (Add pext/pdep as aliases for extract_bits/deposit_bits) - #156630 (Replace `println!` with `assert!` in HashMap documentation examples) - #156644 (Widen the result of `widening_mul`.) - #156653 (Update `sysinfo` version to `0.39.2`) - #156697 (Add diagnostic items for IoBufReader and StdinLock) - #156704 (reduce usage of `box_patterns` in tests)
github-actions Bot
pushed a commit
to rust-lang/stdarch
that referenced
this pull request
Jun 8, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#156709 (stdarch subtree update) - rust-lang/rust#155006 (stabilize `feature(cfg_target_has_atomic_equal_alignment)`) - rust-lang/rust#156444 (Implement `OsStr::split_at`) - rust-lang/rust#156582 (Allow `global_asm!` in statement positions) - rust-lang/rust#156661 (Remove `UncheckedIterator`) - rust-lang/rust#152367 (Derives `Copy` for `ffi::FromBytesUntilNulError`) - rust-lang/rust#156443 (Fix invalid suggestion for parenthesized break) - rust-lang/rust#156606 (Add pext/pdep as aliases for extract_bits/deposit_bits) - rust-lang/rust#156630 (Replace `println!` with `assert!` in HashMap documentation examples) - rust-lang/rust#156644 (Widen the result of `widening_mul`.) - rust-lang/rust#156653 (Update `sysinfo` version to `0.39.2`) - rust-lang/rust#156697 (Add diagnostic items for IoBufReader and StdinLock) - rust-lang/rust#156704 (reduce usage of `box_patterns` in tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #156199
This allows splitting only on valid UTF-8 boundaries, regardless of the platform, which avoids cross-platform landmines.