Implemented PathBuf::into_string#156204
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 7, 2026
Merged
Conversation
…g and OsString::into_string for you
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
5 tasks
Member
|
@bors r+ rollup |
Contributor
rust-bors Bot
pushed a commit
that referenced
this pull request
May 7, 2026
…uwer Rollup of 10 pull requests Successful merges: - #146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - #154025 (Add `keepalive`, `set_keepalive` to `TcpStream` implementations) - #156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI) - #156243 (Move CrateInfo computation after codegen_crate) - #154846 (Add better default spans for the `Ty` impl of `QueryKey`) - #155220 (cg_clif: Don't show verbose run-make cmd output for passing tests) - #156204 (Implemented `PathBuf::into_string`) - #156245 (Move invocation_temp into OutputFilenames) - #156250 (add a few new solver normalization tests) - #156265 (Remove unused `ToStableHashKey` impls.)
rust-timer
added a commit
that referenced
this pull request
May 7, 2026
Rollup merge of #156204 - asder8215:pathbuf_into_string, r=nia-e Implemented `PathBuf::into_string` Noticed from this [Zulip chat](https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.E2.9C.94.20PathBuf.3A.3Ainto_string.3F/with/500962843) that there's been a pretty old [ACP](rust-lang/libs-team#307) on introducing `PathBuf::into_string` that hasn't been implemented yet. I haven't seen anyone link a tracking issue to that [ACP](rust-lang/libs-team#307), so I assume there have been no PRs to complete that ACP. I made a tracking issue for this ACP [here](#156203).
pull Bot
pushed a commit
to LeeeeeeM/miri
that referenced
this pull request
May 8, 2026
…uwer Rollup of 10 pull requests Successful merges: - rust-lang/rust#146273 (lint ImproperCTypes: refactor linting architecture (part 2)) - rust-lang/rust#154025 (Add `keepalive`, `set_keepalive` to `TcpStream` implementations) - rust-lang/rust#156024 (CFI: Fix LTO for `#![no_builtins]` crates with CFI) - rust-lang/rust#156243 (Move CrateInfo computation after codegen_crate) - rust-lang/rust#154846 (Add better default spans for the `Ty` impl of `QueryKey`) - rust-lang/rust#155220 (cg_clif: Don't show verbose run-make cmd output for passing tests) - rust-lang/rust#156204 (Implemented `PathBuf::into_string`) - rust-lang/rust#156245 (Move invocation_temp into OutputFilenames) - rust-lang/rust#156250 (add a few new solver normalization tests) - rust-lang/rust#156265 (Remove unused `ToStableHashKey` impls.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed from this Zulip chat that there's been a pretty old ACP on introducing
PathBuf::into_stringthat hasn't been implemented yet. I haven't seen anyone link a tracking issue to that ACP, so I assume there have been no PRs to complete that ACP.I made a tracking issue for this ACP here.