Skip to content

Add missing dyn keyword to trait_alias page of the Unstable Book#155610

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Omnikar:trait-alias-docs-fix
Apr 22, 2026
Merged

Add missing dyn keyword to trait_alias page of the Unstable Book#155610
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Omnikar:trait-alias-docs-fix

Conversation

@Omnikar
Copy link
Copy Markdown
Contributor

@Omnikar Omnikar commented Apr 21, 2026

There seemed to be a small typo in the Rust Unstable Book page for the trait_alias feature, where a variable is declared as &Bar for a trait Bar, rather than &dyn Bar.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 21, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 72 candidates
  • Random selection from 18 candidates

@mejrs
Copy link
Copy Markdown
Contributor

mejrs commented Apr 21, 2026

r? me

Thanks!

As an aside, this isn't a typo exactly; this works on the 2015 edition. We made the dyn keyword required on edition 2021. I guess the example is just that old.

@bors r+

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 21, 2026

📌 Commit 2863ed6 has been approved by mejrs

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 21, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 22, 2026
Add missing `dyn` keyword to `trait_alias` page of the Unstable Book

There seemed to be a small typo in the Rust Unstable Book page for the `trait_alias` feature, where a variable is declared as `&Bar` for a trait `Bar`, rather than `&dyn Bar`.
rust-bors Bot pushed a commit that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - #155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - #155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - #155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - #154874 (Fix ICE for inherited const conditions on const closures)
 - #155605 (std: Update support for `wasm32-wasip3`)
 - #155613 (c-variadic: tweak `std` docs)
 - #155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
@rust-bors rust-bors Bot merged commit 0ab2cdf into rust-lang:main Apr 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 22, 2026
rust-timer added a commit that referenced this pull request Apr 22, 2026
Rollup merge of #155610 - Omnikar:trait-alias-docs-fix, r=mejrs

Add missing `dyn` keyword to `trait_alias` page of the Unstable Book

There seemed to be a small typo in the Rust Unstable Book page for the `trait_alias` feature, where a variable is declared as `&Bar` for a trait `Bar`, rather than `&dyn Bar`.
github-actions Bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Apr 22, 2026
Rollup of 7 pull requests

Successful merges:

 - rust-lang/rust#155589 (Forbid `check-pass`/`build-pass`/`run-pass` directives in incremental tests)
 - rust-lang/rust#155610 (Add missing `dyn` keyword to `trait_alias` page of the Unstable Book)
 - rust-lang/rust#155615 (test cleanups for `ui/derives` and `ui/deriving`)
 - rust-lang/rust#154874 (Fix ICE for inherited const conditions on const closures)
 - rust-lang/rust#155605 (std: Update support for `wasm32-wasip3`)
 - rust-lang/rust#155613 (c-variadic: tweak `std` docs)
 - rust-lang/rust#155619 (Remove a bunch of unnecessary explicit lifetimes from the ast validator)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants