turn some long-deprecated -C options into errors#154498
turn some long-deprecated -C options into errors#154498rust-bors[bot] merged 3 commits intorust-lang:mainfrom
Conversation
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
8826f95 to
e754f88
Compare
This comment has been minimized.
This comment has been minimized.
e754f88 to
8813c8c
Compare
This comment has been minimized.
This comment has been minimized.
8813c8c to
957ca22
Compare
|
Can you please also update https://github.com/rust-lang/rust/blob/main/src/doc/rustc/src/codegen-options/index.md? |
|
A GitHub search finds a bunch of cases of inline-threshold, from a quick skim it looks like it's set in two relatively popular fuzzing/coverage related libraries:
-Cno-stack-check appears in: -Car is much harder to search for, I didn't find any cases, but I think we should cut PRs and get them merged at least against the above cases. Doing a |
|
Thanks for the search!
|
fd0b941 to
d78c023
Compare
This comment has been minimized.
This comment has been minimized.
d78c023 to
e49e85b
Compare
| @@ -1,2 +0,0 @@ | |||
| warning: `-C ar`: this option is deprecated and does nothing | |||
There was a problem hiding this comment.
Could we keep test for the new hard errors instead of deleting these tests outright?
There was a problem hiding this comment.
I could add one of them back, but it seems kinda pointless to me to test the same thing 4 times.
e49e85b to
9af2553
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=fmease |
|
📋 This PR cannot be approved because it currently has the following label: |
|
@bors r+ |
…uwer Rollup of 7 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #154498 (turn some long-deprecated -C options into errors) - #155734 (Reject outer attributes on `cfg_select` branches) - #156123 (Simplify the creation of synthetic HIR.) - #156175 (Dep graph cleanups) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)
…uwer Rollup of 7 pull requests Successful merges: - #156236 (resolve: Remove `MacroData`) - #156298 (Rename the unstable integer `extend` function to `widen`) - #154498 (turn some long-deprecated -C options into errors) - #155734 (Reject outer attributes on `cfg_select` branches) - #156123 (Simplify the creation of synthetic HIR.) - #156175 (Dep graph cleanups) - #156214 (Do not cache `lints_that_dont_need_to_run` across sessions)
Rollup merge of #154498 - RalfJung:option-deprecations, r=fmease turn some long-deprecated -C options into errors - `-Car` has been documented to do nothing for more than 8 years (691ab6c) and causes a warning for more than a year (#135126). - `-Cno-stack-check` has been made a NOP and deprecated with a warning more than 9 years ago (c670293) - `-Cinline-threshold` has been made a NOP and deprecated with a warning almost 2 years ago (#124712). With them being ignored there's always a risk someone thinks they'll do something and they don't notice the warning. I think these have been deprecated for long enough that we can turn them into hard errors. Also change the type of these fields to `()` so there's no information here that the rest of the compiler could use. This supersedes the `rustc_lint_opt_deny_field_access` trick. MCP: rust-lang/compiler-team#978
-Carhas been documented to do nothing for more than 8 years (691ab6c) and causes a warning for more than a year (mark deprecated option as deprecated in rustc_session to remove copypasta and small refactor #135126).-Cno-stack-checkhas been made a NOP and deprecated with a warning more than 9 years ago (c670293)-Cinline-thresholdhas been made a NOP and deprecated with a warning almost 2 years ago (Deprecate no-op codegen option-Cinline-threshold=...#124712).With them being ignored there's always a risk someone thinks they'll do something and they don't notice the warning. I think these have been deprecated for long enough that we can turn them into hard errors.
Also change the type of these fields to
()so there's no information here that the rest of the compiler could use. This supersedes therustc_lint_opt_deny_field_accesstrick.MCP: rust-lang/compiler-team#978