Skip to content

Start migrating DecorateDiagCompat::Builtin items to DecorateDiagCompat::Dynamic#154120

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag
Mar 21, 2026
Merged

Start migrating DecorateDiagCompat::Builtin items to DecorateDiagCompat::Dynamic#154120
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
GuillaumeGomez:migrate-diag

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Mar 19, 2026

Part of #153099.

End goal being to completely remove the two steps currently required by DecorateDiagCompat::Builtin and remove duplicated types.

r? @JonathanBrouwer

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 19, 2026
@GuillaumeGomez GuillaumeGomez marked this pull request as ready for review March 19, 2026 23:41
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 19, 2026

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 19, 2026

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 19, 2026
Comment thread compiler/rustc_parse/src/errors.rs
Comment thread compiler/rustc_parse/src/parser/expr.rs Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Mar 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment thread compiler/rustc_parse/src/lexer/mod.rs
Copy link
Copy Markdown
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Mar 20, 2026

📌 Commit 0e3e647 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026
rust-bors Bot pushed a commit that referenced this pull request Mar 21, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154154 (Emit fewer errors for incorrect rtn and `=` -> `:` typos in bindings)
 - #154155 (tests/ui/async-await/drop-option-future.rs: New regression test)
 - #146961 (Allow passing `expr` metavariable as `cfg` predicate)
 - #154118 (don't suggest non-deriveable traits for unions)
 - #154120 (Start migrating `DecorateDiagCompat::Builtin` items to `DecorateDiagCompat::Dynamic`)
 - #154156 (Moving issue-52049 to borrowck)
rust-bors Bot pushed a commit that referenced this pull request Mar 21, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #154154 (Emit fewer errors for incorrect rtn and `=` -> `:` typos in bindings)
 - #154155 (tests/ui/async-await/drop-option-future.rs: New regression test)
 - #146961 (Allow passing `expr` metavariable as `cfg` predicate)
 - #154118 (don't suggest non-deriveable traits for unions)
 - #154120 (Start migrating `DecorateDiagCompat::Builtin` items to `DecorateDiagCompat::Dynamic`)
 - #154156 (Moving issue-52049 to borrowck)
@rust-bors rust-bors Bot merged commit 84cb74a into rust-lang:main Mar 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 21, 2026
@GuillaumeGomez GuillaumeGomez deleted the migrate-diag branch March 21, 2026 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants