Add optional CI job to build the compiler with the parallel frontend#153726
Add optional CI job to build the compiler with the parallel frontend#153726Kobzol wants to merge 2 commits intorust-lang:mainfrom
Conversation
|
@bors try jobs=x86_64-gnu-parallel-frontend |
This comment has been minimized.
This comment has been minimized.
Add optional CI job to run tests with the parallel frontend try-job: x86_64-gnu-parallel-frontend
There was a problem hiding this comment.
General idea seems good, some clarifications
@rustbot author
| // Auto CI jobs must all "fail-fast" to avoid wasting Auto CI resources. For instance, `tidy`. | ||
| for auto_job in &db.auto_jobs { | ||
| if auto_job.continue_on_error == Some(true) { | ||
| return Err(anyhow!( | ||
| "Auto job `{}` cannot have `continue_on_error: true`", | ||
| auto_job.name | ||
| )); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggestion: can we please special-case x86_64-gnu-parallel-frontend to opt-out of this check instead of relaxing this for all auto CI jobs?
I believe this is still an important property to maintain apart from x86_64-gnu-parallel-frontend.
That, or we call these kind of auto jobs optional-* (optional-x86_64-gnu-parallel-frontend for instance) then permit continue_on_error for optional-*.
| # Run the test suite with 2 parallel frontend threads | ||
| ENV SCRIPT python3 ../x.py --stage 2 test --set rust.parallel-frontend-threads=2 |
There was a problem hiding this comment.
Question: wait, to clarify
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially.
shouldn't this comment say sth more like
Build in-tree rustc/std with parallel frontend threads.
Tests are still compiled serially at the moment (intended to be changed in follow-ups).
?
Discussed on Zulip.
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu