Skip to content

Fix that ./x test --no-doc actually keeps the same behaviour for backwards compatability#153725

Open
Urhengulas wants to merge 1 commit intorust-lang:mainfrom
ferrocene:jh/fix-x-test-no-doc
Open

Fix that ./x test --no-doc actually keeps the same behaviour for backwards compatability#153725
Urhengulas wants to merge 1 commit intorust-lang:mainfrom
ferrocene:jh/fix-x-test-no-doc

Conversation

@Urhengulas
Copy link
Contributor

@Urhengulas Urhengulas commented Mar 11, 2026

In #153143 the ./x test --no-doc flag was renamed to --all-targets. I added a commit that keeps the --no-doc flag for backwards compatibility, but unfortunately I forgot to actually keep the behaviour the same, which is fixed by this PR.

r? @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 11, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 11, 2026

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

@Kobzol
Copy link
Member

Kobzol commented Mar 11, 2026

Ah, right, good catch. Thanks!

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 11, 2026

📌 Commit 70f87db has been approved by Kobzol

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2026
@Urhengulas Urhengulas mentioned this pull request Mar 11, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153725 - ferrocene:jh/fix-x-test-no-doc, r=…
91fcfb3 
…Kobzol

Fix that `./x test --no-doc` actually keeps the same behaviour for backwards compatability

In rust-lang#153143 the `./x test --no-doc` flag was renamed to `--all-targets`.  I added a commit that keeps the `--no-doc` flag for backwards compatibility, but unfortunately I forgot to actually keep the behaviour the same, which is fixed by this PR.

r? @Kobzol
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 11, 2026
Closed
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Mar 11, 2026

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
    ╭▸ src/bootstrap/src/core/config/flags.rs:575:34
    │
575 │                 // for backwards compatability --no-doc keeps working
    ╰╴                                 ━━━━━━━━━━━━━
rerun tidy with `--extra-checks=spellcheck --bless` to fix typos
tidy [extra_checks:spellcheck]: checks with external tool 'typos' failed
tidy [extra_checks:spellcheck]: FAIL
yarn install v1.22.22
warning package.json: No license field
warning ../../package.json: License should be a valid SPDX license expression
warning No license field
[1/4] Resolving packages...
---
linting javascript files
Running eslint on rustdoc JS files
info: ES-Check: there were no ES version matching errors!  🎉
typechecking javascript files
tidy: The following check failed: extra_checks:spellcheck
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy --root-path=/checkout --cargo-path=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo --output-dir=/checkout/obj/build --concurrency=4 --npm-path=/node/bin/yarn --ci=true --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1618:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1387:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
  local time: Wed Mar 11 16:41:27 UTC 2026
  network time: Wed, 11 Mar 2026 16:41:27 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 11, 2026

@bors r-
#153728
Rollup PR ci failed

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 11, 2026

This pull request was unapproved.

This PR was contained in a rollup (#153728), which was unapproved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Urhengulas @rustbot @Kobzol @rust-log-analyzer @JonathanBrouwer