Skip to content

mir-opt: Drop invalid debuginfos after SingleUseConsts.#153660

Open
dianqk wants to merge 1 commit intorust-lang:mainfrom
dianqk:dbg-single-use-const
Open

mir-opt: Drop invalid debuginfos after SingleUseConsts.#153660
dianqk wants to merge 1 commit intorust-lang:mainfrom
dianqk:dbg-single-use-const

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Mar 10, 2026

Fixes #153601.

@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2026

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 10, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 10, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir, mir-opt
  • compiler, mir, mir-opt expanded to 69 candidates
  • Random selection from 17 candidates

dianqk
dianqk commented Mar 10, 2026
View reviewed changes
tests/mir-opt/debuginfo/single_use_consts.rs
@@ -0,0 +1,25 @@
//@ test-mir-pass: SingleUseConsts
//@ compile-flags: -g -Zinline-mir -Zmir-enable-passes=+InstSimplify-after-simplifycfg,+DeadStoreElimination-final,+DestinationPropagation -Zvalidate-mir
//! Regression test for <https://github.com/rust-lang/rust/issues/33013>.
Copy link
Member Author

@dianqk dianqk Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://rust.godbolt.org/z/na58o8Mn8

@rust-log-analyzer

This comment has been minimized.

Sign in to view
1 similar comment
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@dianqk dianqk force-pushed the dbg-single-use-const branch from 5b5595b to 86da931 Compare March 10, 2026 21:40
@mati865
Copy link
Member

mati865 commented Mar 11, 2026

Nice, thanks.

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 11, 2026

📌 Commit 86da931 has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#153660 - dianqk:dbg-single-use-const, r=mat…
93757ee 
…i865

mir-opt: Drop invalid debuginfos after SingleUseConsts.

Fixes rust-lang#153601.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Mar 11, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Mar 11, 2026
@bors
Auto merge of #153723 - JonathanBrouwer:rollup-zP7J3H2, r=JonathanBro…
0d711f1 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153571 (Avoid ICE when an EII declaration conflicts with a constructor)
 - #153581 (Simplify `type_of_opaque`.)
 - #153611 (interpret: go back to regular string interpolation for error messages)
 - #153635 (Unify same-span labels in move error diagnostics)
 - #153660 (mir-opt: Drop invalid debuginfos after SingleUseConsts.)
 - #153685 (Introduce `for_each_query_vtable!` to move more code out of query macros)
 - #153671 (Make Enzyme has dependent on LLVM hash)
 - #153710 (remove `.ftl` checks from tidy)
 - #153720 (doc/rustc: clarify how to contact arm-maintainers)
rust-bors bot pushed a commit that referenced this pull request Mar 11, 2026
@bors
Auto merge of #153723 - JonathanBrouwer:rollup-zP7J3H2, r=JonathanBro…
b5d3e7e 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153571 (Avoid ICE when an EII declaration conflicts with a constructor)
 - #153581 (Simplify `type_of_opaque`.)
 - #153611 (interpret: go back to regular string interpolation for error messages)
 - #153635 (Unify same-span labels in move error diagnostics)
 - #153660 (mir-opt: Drop invalid debuginfos after SingleUseConsts.)
 - #153685 (Introduce `for_each_query_vtable!` to move more code out of query macros)
 - #153671 (Make Enzyme has dependent on LLVM hash)
 - #153710 (remove `.ftl` checks from tidy)
 - #153720 (doc/rustc: clarify how to contact arm-maintainers)
rust-bors bot pushed a commit that referenced this pull request Mar 11, 2026
@bors
Auto merge of #153723 - JonathanBrouwer:rollup-zP7J3H2, r=JonathanBro…
937011f 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #153571 (Avoid ICE when an EII declaration conflicts with a constructor)
 - #153581 (Simplify `type_of_opaque`.)
 - #153611 (interpret: go back to regular string interpolation for error messages)
 - #153635 (Unify same-span labels in move error diagnostics)
 - #153660 (mir-opt: Drop invalid debuginfos after SingleUseConsts.)
 - #153685 (Introduce `for_each_query_vtable!` to move more code out of query macros)
 - #153671 (Make Enzyme has dependent on LLVM hash)
 - #153710 (remove `.ftl` checks from tidy)
 - #153720 (doc/rustc: clarify how to contact arm-maintainers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mati865 mati865

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

4 participants

@dianqk @rustbot @rust-log-analyzer @mati865