Skip to content

rustdoc-json: Improve docs for ItemEnum::item_kind#153627

Open
aDotInTheVoid wants to merge 1 commit intorust-lang:mainfrom
aDotInTheVoid:rustdocsdocs
Open

rustdoc-json: Improve docs for ItemEnum::item_kind#153627
aDotInTheVoid wants to merge 1 commit intorust-lang:mainfrom
aDotInTheVoid:rustdocsdocs

Conversation

@aDotInTheVoid
Copy link
Member

@aDotInTheVoid aDotInTheVoid commented Mar 9, 2026

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @Enselic, @obi1kenobi

@rustbot rustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 9, 2026
@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Mar 9, 2026

Thanks! r=me once CI is happy.

@aDotInTheVoid
Copy link
Member Author

aDotInTheVoid commented Mar 10, 2026

@bors r=GuillaumeGomez rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 10, 2026

📌 Commit ca9bd0d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2026
@matthiaskrgr
Rollup merge of rust-lang#153627 - aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d 
…laumeGomez

rustdoc-json: Improve docs for `ItemEnum::item_kind`

Fixes rust-lang#153279 (comment)

r? @GuillaumeGomez

CC @LukeMathWalker
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aDotInTheVoid @rustbot @GuillaumeGomez