Replace the try_mark_green hook with direct calls to tcx.dep_graph#153561
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 8, 2026
Merged
Replace the try_mark_green hook with direct calls to tcx.dep_graph#153561rust-bors[bot] merged 1 commit intorust-lang:mainfrom
try_mark_green hook with direct calls to tcx.dep_graph#153561rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
All of the existing call sites are directly touching `tcx.dep_graph` anyway, so the extra layer of indirection provides no real benefit.
Member
Author
|
Originally I was planning to replace the hook with a plain TyCtxt method, but then I noticed that there was no real reason not to just inline it into all callers anyway. |
nnethercote
approved these changes
Mar 8, 2026
Contributor
|
@bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 8, 2026
…cote Replace the `try_mark_green` hook with direct calls to `tcx.dep_graph` All of the existing call sites are directly touching `tcx.dep_graph` anyway, so the extra layer of indirection provides no real benefit. There should be no change to compiler behaviour. r? nnethercote (or compiler)
This was referenced Mar 8, 2026
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2026
…uwer Rollup of 4 pull requests Successful merges: - #153464 (Use `&C::Key` less in queries.) - #153553 (Remove the `rustc_data_structures::assert_matches!` re-exports) - #153561 (Replace the `try_mark_green` hook with direct calls to `tcx.dep_graph`) - #153564 (rendering interpreter OOM as OOM instead of ICE)
rust-timer
added a commit
that referenced
this pull request
Mar 8, 2026
Rollup merge of #153561 - Zalathar:try-mark-green, r=nnethercote Replace the `try_mark_green` hook with direct calls to `tcx.dep_graph` All of the existing call sites are directly touching `tcx.dep_graph` anyway, so the extra layer of indirection provides no real benefit. There should be no change to compiler behaviour. r? nnethercote (or compiler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the existing call sites are directly touching
tcx.dep_graphanyway, so the extra layer of indirection provides no real benefit.There should be no change to compiler behaviour.
r? nnethercote (or compiler)