Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>] by aerooneqq · Pull Request #153494 · rust-lang/rust

aerooneqq · 2026-03-06T13:03:56Z

This PR allocates trait candidates on HIR arena and replaces remove with get in ResolverAstLowering. First step for #153489.

r? @petrochenkov

petrochenkov · 2026-03-06T13:20:15Z

@bors try @rust-timer queue

…, r=<try> Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]

rust-bors · 2026-03-06T15:32:37Z

☀️ Try build successful (CI)
Build commit: ff56b27 (ff56b275d82baa6b2f18a05cfdae3eb869ce720f, parent: f82485388963286763f8c8a9261ac227627f6a18)

rust-timer · 2026-03-06T17:23:09Z

Finished benchmarking commit (ff56b27): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	10
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	1

Max RSS (memory usage)

Results (primary -1.5%, secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.5%	[-2.2%, -0.7%]	2
Improvements ✅ (secondary)	-3.1%	[-4.5%, -1.7%]	2
All ❌✅ (primary)	-1.5%	[-2.2%, -0.7%]	2

Cycles

Results (primary -0.1%, secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.2%, 2.0%]	2

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	11
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	11

Bootstrap: 480.442s -> 483.222s (0.58%)
Artifact size: 397.10 MiB -> 395.17 MiB (-0.48%)

petrochenkov · 2026-03-07T05:00:24Z

@bors r+ rollup=maybe

rust-bors · 2026-03-07T05:00:27Z

📌 Commit dc31c15 has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…o-hir-arena, r=petrochenkov Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>] This PR allocates trait candidates on HIR arena and replaces `remove` with `get` in `ResolverAstLowering`. First step for rust-lang#153489. r? @petrochenkov

rust-bors · 2026-03-07T16:22:35Z

⌛ Testing commit dc31c15 with merge a25cb8a...

Workflow: https://github.com/rust-lang/rust/actions/runs/22802635722

@petrochenkov

…, r=petrochenkov Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>] This PR allocates trait candidates on HIR arena and replaces `remove` with `get` in `ResolverAstLowering`. First step for #153489. r? @petrochenkov

JonathanBrouwer · 2026-03-07T16:38:00Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-03-07T16:38:03Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/22802635722

The next pull request likely to be tested is #153541.

…uwer Rollup of 2 pull requests Successful merges: - #153494 (Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]) - #153465 (Fix incorrect rustdoc JSON representation of `#[doc(test(..))]` attrs.)

@petrochenkov

Rollup merge of #153494 - aerooneqq:boxed-trait-candidates-to-hir-arena, r=petrochenkov Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>] This PR allocates trait candidates on HIR arena and replaces `remove` with `get` in `ResolverAstLowering`. First step for #153489. r? @petrochenkov

Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]

dc31c15

rustbot assigned petrochenkov Mar 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 6, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026

Auto merge of #153494 - aerooneqq:boxed-trait-candidates-to-hir-arena…

ff56b27

…, r=<try> Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026

petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2026

petrochenkov approved these changes Mar 6, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 7, 2026

JonathanBrouwer mentioned this pull request Mar 7, 2026

Rollup of 3 pull requests #153538

Closed

JonathanBrouwer mentioned this pull request Mar 7, 2026

Rollup of 2 pull requests #153541

Merged

rust-bors bot merged commit 10f2c48 into rust-lang:main Mar 7, 2026
12 of 13 checks passed

rustbot added this to the 1.96.0 milestone Mar 7, 2026

aerooneqq deleted the boxed-trait-candidates-to-hir-arena branch March 9, 2026 17:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]#153494

Replace Box<[TraitCandidate]> with &'hir [TraitCandidate<'hir>]#153494
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
aerooneqq:boxed-trait-candidates-to-hir-arena

aerooneqq commented Mar 6, 2026 •

edited by rustbot

Loading

Uh oh!

petrochenkov commented Mar 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 6, 2026

Uh oh!

petrochenkov commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026 •

edited

Loading

Uh oh!

JonathanBrouwer commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aerooneqq commented Mar 6, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

petrochenkov commented Mar 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 6, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

petrochenkov commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aerooneqq commented Mar 6, 2026 •

edited by rustbot

Loading

rust-bors bot commented Mar 7, 2026 •

edited

Loading