Skip to content

Add missing track_caller to overflowing trait methods#153480

Open
RaphiMuehlbacher wants to merge 1 commit intorust-lang:mainfrom
RaphiMuehlbacher:track-caller
Open

Add missing track_caller to overflowing trait methods#153480
RaphiMuehlbacher wants to merge 1 commit intorust-lang:mainfrom
RaphiMuehlbacher:track-caller

Conversation

@RaphiMuehlbacher
Copy link

@RaphiMuehlbacher RaphiMuehlbacher commented Mar 6, 2026 •
edited by rustbot
Loading

Fixes #152599 by adding #[track_caller] to arithmetic trait methods (Neg, Shl, ShlAssign, Shr and ShrAssign) so overflow panics report the correct call site instead of the trait definition.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 9, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
@bors
Auto merge of #153480 - RaphiMuehlbacher:track-caller, r=<try>
4e1aaaa 
Add missing `track_caller` to overflowing trait methods
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

☀️ Try build successful (CI)
Build commit: 4e1aaaa (4e1aaaaad65d1addb370b9d061c3d8a639d37b8c, parent: b41f22de2a13a0babd28771e96feef4c309f54aa)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 9, 2026

Finished benchmarking commit (4e1aaaa): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.1% [0.1%, 0.1%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -9.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -9.9% [-9.9%, -9.9%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -9.9% [-9.9%, -9.9%] 1

Cycles

Results (secondary 2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.2%, 3.9%] 8
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.3% [-1.3%, -1.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 478.517s -> 480.84s (0.49%)
Artifact size: 395.02 MiB -> 394.98 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overflow errors give wrong position information when called via traits

4 participants

@RaphiMuehlbacher @rustbot @Mark-Simulacrum @rust-timer