Use a `BucketIndex` abstraction in `VecCache` by Zalathar · Pull Request #153381 · rust-lang/rust

Zalathar · 2026-03-04T05:42:01Z

(Currently a draft while I wait for perf results.)

Zalathar · 2026-03-04T05:42:14Z

Use a `BucketIndex` abstraction in `VecCache`

rust-bors · 2026-03-04T07:52:46Z

☀️ Try build successful (CI)
Build commit: 4d80320 (4d803208867d307ab1a5eafceedee869f54d2c93, parent: d933cf483edf1605142ac6899ff32536c0ad8b22)

Zalathar · 2026-03-04T09:40:47Z

@bors try @rust-timer queue

Use a `BucketIndex` abstraction in `VecCache`

Zalathar · 2026-03-04T11:49:04Z

@bors try cancel

rust-bors · 2026-03-04T11:49:07Z

Try build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/22663671052

Zalathar · 2026-03-04T11:49:17Z

@bors try

Use a `BucketIndex` abstraction in `VecCache`

rust-bors · 2026-03-04T13:59:24Z

☀️ Try build successful (CI)
Build commit: dbf3154 (dbf31543aad20f117d285cb93d6c43a0ab2595a2, parent: d933cf483edf1605142ac6899ff32536c0ad8b22)

rust-timer · 2026-03-04T15:08:09Z

Finished benchmarking commit (dbf3154): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	4
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Max RSS (memory usage)

Results (secondary -5.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.3%	[-5.3%, -5.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[2.2%, 8.4%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-18.9%	[-18.9%, -18.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	23
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	56
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	23

Bootstrap: 481.183s -> 481.762s (0.12%)
Artifact size: 394.90 MiB -> 394.99 MiB (0.02%)

Zalathar · 2026-03-04T23:14:07Z

@bors try @rust-timer queue

Use a `BucketIndex` abstraction in `VecCache`

rust-bors · 2026-03-05T01:28:46Z

☀️ Try build successful (CI)
Build commit: 12ea9b1 (12ea9b1875f3ec1937e91e8a885f1ddefbff660f, parent: b90dc1e597db0bbc0cab0eccb39747b1a9d7e607)

rust-timer · 2026-03-05T02:09:09Z

Finished benchmarking commit (12ea9b1): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.2%, secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.9%	[5.9%, 5.9%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-7.4%	[-7.4%, -7.4%]	1
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Cycles

Results (secondary 6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.9%	[6.9%, 6.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.576s -> 480.834s (0.26%)
Artifact size: 397.00 MiB -> 394.97 MiB (-0.51%)

Zalathar · 2026-03-05T02:13:40Z

@bors try @rust-timer queue

Use a `BucketIndex` abstraction in `VecCache`

rust-bors · 2026-03-05T04:23:20Z

☀️ Try build successful (CI)
Build commit: fdf7f57 (fdf7f57e5614728ff85ba1ac291bb819d49368da, parent: b55e20ad905a336395ca80863488d0827712d067)

rust-timer · 2026-03-05T05:31:40Z

Finished benchmarking commit (fdf7f57): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.5%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[1.4%, 2.7%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[1.4%, 2.7%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 478.218s -> 480.235s (0.42%)
Artifact size: 394.94 MiB -> 394.91 MiB (-0.01%)

Zalathar · 2026-03-05T07:15:30Z

Closing this draft to have a cleaner comment history for the non-draft PR.

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153381 - Zalathar:bucket-index, r=<try>

4d80320

Use a `BucketIndex` abstraction in `VecCache`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 4, 2026

Zalathar force-pushed the bucket-index branch from d5a3e41 to 7dbe3e6 Compare March 4, 2026 09:39

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153381 - Zalathar:bucket-index, r=<try>

2c9a384

Use a `BucketIndex` abstraction in `VecCache`

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153381 - Zalathar:bucket-index, r=<try>

dbf3154

Use a `BucketIndex` abstraction in `VecCache`

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Mar 4, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #153381 - Zalathar:bucket-index, r=<try>

12ea9b1

Use a `BucketIndex` abstraction in `VecCache`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 4, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2026

Use a BucketIndex abstraction in VecCache

dadeb93

Zalathar force-pushed the bucket-index branch from 4a4bbd4 to 03c27ee Compare March 5, 2026 02:10

Zalathar added 2 commits March 5, 2026 13:10

(DO NOT MERGE) Various tweaks to try to affect perf

b6ea78c

Remove unsafe from_raw

ab16df0

Zalathar force-pushed the bucket-index branch from 03c27ee to ab16df0 Compare March 5, 2026 02:12

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 5, 2026

Auto merge of #153381 - Zalathar:bucket-index, r=<try>

fdf7f57

Use a `BucketIndex` abstraction in `VecCache`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2026

Zalathar closed this Mar 5, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 5, 2026

Zalathar mentioned this pull request Mar 5, 2026

Use a safe BucketIndex abstraction in VecCache #153434

Open

Uh oh!

Conversation

Zalathar commented Mar 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Mar 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

Zalathar commented Mar 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Zalathar commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

Zalathar commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 4, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Zalathar commented Mar 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 5, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 5, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 5, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 5, 2026

Overall result: no relevant changes - no action needed

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Zalathar commented Mar 4, 2026 •

edited by rustbot

Loading