move never type tests to subdirectories and add some comments#153346
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 7, 2026
Merged
move never type tests to subdirectories and add some comments#153346rust-bors[bot] merged 2 commits intorust-lang:mainfrom
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Member
|
r? me |
jieyouxu
reviewed
Mar 4, 2026
Member
There was a problem hiding this comment.
Nice. Looks good, though you'll need to rebless the issues.txt list or give the regress/issue-*.rs ones more descriptive test names.
@rustbot author
0558b3c to
0e5e529
Compare
0e5e529 to
d1a3f24
Compare
WaffleLapkin
commented
Mar 4, 2026
Member
Author
There was a problem hiding this comment.
there is no way to make this test actually test something interesting. it used to test the cycle detection in inhabitedness check, but since we no longer follow references for it, there is no way to get a cycle without causing the type to be infinitely sized.
Member
Author
|
@rustbot review |
jieyouxu
approved these changes
Mar 4, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Actually just to avoid easy oopsie, r=me after PR CI is green :D |
This comment has been minimized.
This comment has been minimized.
d1a3f24 to
b7eee61
Compare
jieyouxu
reviewed
Mar 6, 2026
Member
There was a problem hiding this comment.
Just noticed this one problem, you can r=me after
@rustbot author
b7eee61 to
05174fb
Compare
Member
Author
|
@bors r=jieyouxu |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 7, 2026
…uwer Rollup of 5 pull requests Successful merges: - #149937 (spliit out `linker-info` from `linker-messages`) - #153503 (Fallback to fat LTO for -Clto=thin in cg_gcc) - #153346 (move never type tests to subdirectories and add some comments) - #153371 (Fix LegacyKeyValueFormat report from docker build: arm) - #153508 (Clean up the eager formatting API)
rust-timer
added a commit
that referenced
this pull request
Mar 7, 2026
Rollup merge of #153346 - WaffleLapkin:sometimes-test, r=jieyouxu move never type tests to subdirectories and add some comments This hopefully makes things a little bit clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopefully makes things a little bit clearer