Skip to content

MGCA: fix type error handling for const array and tuple lowering logic#153345

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Human9000-bit:mgca-diagnostics-fix
Mar 3, 2026
Merged

MGCA: fix type error handling for const array and tuple lowering logic#153345
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Human9000-bit:mgca-diagnostics-fix

Conversation

@Human9000-bit
Copy link
Contributor

@Human9000-bit Human9000-bit commented Mar 3, 2026

It's a simple fix; just needed to handle Ty::Error in lower_const_arg_array and lower_const_arg_tup

Fixes #153254

r? @fmease

@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2026

HIR ty lowering was modified

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 3, 2026
Copy link
Member

@fmease fmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 3, 2026

📌 Commit ee1d0cf has been approved by fmease

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
…, r=fmease

MGCA: fix type error handling for const array and tuple lowering logic

It's a simple fix; just needed to handle Ty::Error in `lower_const_arg_array` and `lower_const_arg_tup`

Fixes rust-lang#153254

r? @fmease
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
…, r=fmease

MGCA: fix type error handling for const array and tuple lowering logic

It's a simple fix; just needed to handle Ty::Error in `lower_const_arg_array` and `lower_const_arg_tup`

Fixes rust-lang#153254

r? @fmease
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152164 (Lint unused features)
 - #152712 (Use shell-words to parse output from llvm-config)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 4 pull requests

Successful merges:

 - #152712 (Use shell-words to parse output from llvm-config)
 - #152911 (Stabilize `control_flow_ok`)
 - #153223 (Fix LegacyKeyValueFormat report from docker build: host-aarch64)
 - #153345 (MGCA: fix type error handling for const array and tuple lowering logic)
@rust-bors rust-bors bot merged commit 0605ef5 into rust-lang:main Mar 3, 2026
11 checks passed
rust-timer added a commit that referenced this pull request Mar 3, 2026
Rollup merge of #153345 - Human9000-bit:mgca-diagnostics-fix, r=fmease

MGCA: fix type error handling for const array and tuple lowering logic

It's a simple fix; just needed to handle Ty::Error in `lower_const_arg_array` and `lower_const_arg_tup`

Fixes #153254

r? @fmease
@rustbot rustbot added this to the 1.96.0 milestone Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mGCA: Syntactic type mismatch diagnostic can leak {type error} for forbidden inferred types _ in the type of type-level const items

3 participants