Add #![unstable_removed(..)] attribute to track removed features#153335
Add #![unstable_removed(..)] attribute to track removed features#153335Ozzy1423 wants to merge 2 commits intorust-lang:mainfrom
Conversation
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
|
Failed to set assignee to
|
| let word = param.path().word(); | ||
| match word.map(|i| i.name) { | ||
| Some(sym::feature) => { | ||
| insert_value_into_option_or_error(cx, ¶m, &mut feature, word.unwrap())? |
There was a problem hiding this comment.
you can avoid these unwraps using Some(word@sym::...)
There was a problem hiding this comment.
couldn't get word@sym to work (word was then the wrong type for the insert_value... function) so just added an explicit check
|
Reminder, once the PR becomes ready for a review, use |
c384f06 to
4966708
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
4966708 to
e4908ff
Compare
|
I've now provided an example, moving the concat_idents feature removal tracking to the new attribute in the second commit. |
|
r=me on behalf of compiler after @nia-e brings it up with T-libs on wednesday. Ping me if you need the r+ |
|
It would be worth checking if there's any in-tree dev docs on (removing) unstable features and updating them to mention this also |
Adds the #![unstable_removed(..)] attribute to enable tracking removed library features.
Produce an error when a removed attribute is used.
Add a test that it works.
For #141617
I will go through and add the removed features in another commit, just wanted to post this for a review of the code.
TODO:
Find out the list of removed features and add them
Which file should I add them to?
r? @jyn514