Fix compile error in std::fs impl on VEXos target#153246
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 1, 2026
Merged
Fix compile error in std::fs impl on VEXos target#153246rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @joboet rustbot has assigned @joboet. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 1, 2026
…uwer Rollup of 6 pull requests Successful merges: - #153130 (std: move `getpid` to `sys::process`) - #152549 (Revert "resolve: Downgrade `ambiguous_glob_imports` to warn-by-default") - #153231 (diags: Pass `DiagArgMap` instead of `FluentArgs` into `format_diag_message`) - #153246 (Fix compile error in std::fs impl on VEXos target) - #153255 (Recover feature lang_items for emscripten) - #153257 (update my mailmap)
rust-timer
added a commit
that referenced
this pull request
Mar 1, 2026
Rollup merge of #153246 - vexide:fix/fs-dir, r=joboet Fix compile error in std::fs impl on VEXos target This PR fixes a compile error in the standard library on the `armv7a-vex-v5` target that was caused by there not being a version of the `Dir` struct exported from `std::sys::fs::vexos`. Reading from directories isn't supported on this platform, so the module now re-exports the unsupported version of `Dir`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a compile error in the standard library on the
armv7a-vex-v5target that was caused by there not being a version of theDirstruct exported fromstd::sys::fs::vexos. Reading from directories isn't supported on this platform, so the module now re-exports the unsupported version ofDir.