Update path separators to be available in const context by MikkelPaulson · Pull Request #153196 · rust-lang/rust

MikkelPaulson · 2026-02-27T19:00:11Z

Tracking issue: #153106

This makes platform-dependent secondary path separators available in const context (ie. at compile time). The platform definitions have also been consolidated behind a common macro to prevent transcription errors, whereas previously they were defined 3-4 times per platform.

Questions

I've manually verified that this compiles against each platform. It seems like no unit tests should be required for this change; is that correct?

rustbot · 2026-02-27T19:00:17Z

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, joboet

joboet

I'm not sure the FIXME is necessary, but everything else looks very good!

View changes since this review

library/std/src/sys/path/mod.rs

joboet

Thanks! Just one more thing I noticed.

View changes since this review

library/std/src/sys/path/mod.rs

rustbot · 2026-03-04T10:01:32Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-03-04T14:58:51Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Change reference to imported MAIN_SEP_STR to local MAIN_SEPARATOR_STR, removing an unnecessary import.

MikkelPaulson · 2026-03-04T16:38:53Z

@rustbot ready

joboet · 2026-03-04T17:01:15Z

Great, thanks! Could you please squash your last three commits together? After that, r=me

@bors delegate+

rust-bors · 2026-03-04T17:01:19Z

✌️ @MikkelPaulson, you can now approve this pull request!

If @joboet told you to "r=me" after making some further change, then please make that change and post @bors r=joboet.

* consolidate various representations of separators in std::sys::path into a single macro_rules invocation per platform to save transcription errors * make `std::path::is_separator()` const * new constants `std::path::{SEPARATORS, SEPARATORS_STR}`

joboet · 2026-03-04T17:38:09Z

👍
@bors r+

rust-bors · 2026-03-04T17:38:12Z

📌 Commit 098b1b9 has been approved by joboet

It is now in the queue for this repository.

…uwer Rollup of 12 pull requests Successful merges: - #153402 (miri subtree update) - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153196 (Update path separators to be available in const context) - #153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - #153317 (Abort after `representability` errors) - #153276 (Remove `cycle_fatal` query modifier) - #153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself) - #153414 (Rename translation -> formatting)

Rollup merge of #153196 - MikkelPaulson:const-path-separators, r=joboet Update path separators to be available in const context Tracking issue: #153106 This makes platform-dependent secondary path separators available in const context (ie. at compile time). The platform definitions have also been consolidated behind a common macro to prevent transcription errors, whereas previously they were defined 3-4 times per platform. ### Questions I've manually verified that this compiles against each platform. It seems like no unit tests should be required for this change; is that correct?

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#153402 (miri subtree update) - rust-lang/rust#152164 (Lint unused features) - rust-lang/rust#152801 (Refactor WriteBackendMethods a bit) - rust-lang/rust#153196 (Update path separators to be available in const context) - rust-lang/rust#153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - rust-lang/rust#153317 (Abort after `representability` errors) - rust-lang/rust#153276 (Remove `cycle_fatal` query modifier) - rust-lang/rust#153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - rust-lang/rust#153396 (use `minicore` in some `run-make` tests) - rust-lang/rust#153401 (Migrationg of `LintDiagnostic` - part 7) - rust-lang/rust#153406 (Remove a ping for myself) - rust-lang/rust#153414 (Rename translation -> formatting)

rustbot assigned joboet Feb 27, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 27, 2026

MikkelPaulson mentioned this pull request Feb 27, 2026

Tracking Issue for const path separators #153106

Open

4 tasks

joboet approved these changes Feb 28, 2026

View reviewed changes

library/std/src/sys/path/mod.rs Outdated Show resolved Hide resolved

joboet requested changes Mar 4, 2026

View reviewed changes

library/std/src/sys/path/mod.rs Outdated Show resolved Hide resolved

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2026

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 4, 2026

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Mar 4, 2026

reference local MAIN_SEPARATOR_STR

72de815

Change reference to imported MAIN_SEP_STR to local MAIN_SEPARATOR_STR, removing an unnecessary import.

MikkelPaulson force-pushed the const-path-separators branch from 59411ae to 5004ef4 Compare March 4, 2026 15:08

rustbot removed has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2026

MikkelPaulson force-pushed the const-path-separators branch from e726e49 to 098b1b9 Compare March 4, 2026 17:03

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 4, 2026

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 12 pull requests #153416

Merged

rust-bors bot merged commit 5ff104c into rust-lang:main Mar 5, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 5, 2026

MikkelPaulson deleted the const-path-separators branch March 6, 2026 02:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update path separators to be available in const context#153196

Update path separators to be available in const context#153196
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
MikkelPaulson:const-path-separators

MikkelPaulson commented Feb 27, 2026 •

edited by rustbot

Loading

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

joboet left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

joboet left a comment •

edited by rustbot

Loading

Uh oh!

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

MikkelPaulson commented Mar 4, 2026

Uh oh!

joboet commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

joboet commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

MikkelPaulson commented Feb 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Questions

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joboet left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

rustbot commented Mar 4, 2026

Uh oh!

This comment has been minimized.

MikkelPaulson commented Mar 4, 2026

Uh oh!

joboet commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

joboet commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MikkelPaulson commented Feb 27, 2026 •

edited by rustbot

Loading

joboet left a comment •

edited by rustbot

Loading

joboet left a comment •

edited by rustbot

Loading