extend unpin noalias tests to cover mutable references#152970
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 23, 2026
Merged
extend unpin noalias tests to cover mutable references#152970rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
9d969eb to
9eb102b
Compare
This comment has been minimized.
This comment has been minimized.
9eb102b to
b56949b
Compare
Member
|
@bors r+ |
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 23, 2026
Rollup of 9 pull requests Successful merges: - #152229 (Remove deterministic picking from query cycle handling) - #152970 (extend unpin noalias tests to cover mutable references) - #149783 (stabilize `cfg_select!`) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152366 (Add try_shrink_to and try_shrink_to_fit to Vec) - #152640 (Add direct link to rustc-dev-guide in README) - #152963 (Revert "Stabilize `str_as_str`") - #152984 (Remove redundant call to `check_codegen_attributes_extra` in Inliner) - #152987 (Use `HashStable` derive in more places)
rust-timer
added a commit
that referenced
this pull request
Feb 23, 2026
Rollup merge of #152970 - RalfJung:unpin-noalias-tests, r=Mark-Simulacrum extend unpin noalias tests to cover mutable references #152946 made a change to the logic for this attribute that the test should have flagged as problematic -- but the test only checked `Box`, not `&mut`, and those have independent code paths. So extend the test to also cover `&mut`. @b-naber would be nice if you could confirm that the added tests do fail with your PR.
Contributor
|
Yes, the tests fail with #152946. |
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Feb 24, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#152229 (Remove deterministic picking from query cycle handling) - rust-lang/rust#152970 (extend unpin noalias tests to cover mutable references) - rust-lang/rust#149783 (stabilize `cfg_select!`) - rust-lang/rust#151744 (fix refining_impl_trait suggestion with return_type_notation) - rust-lang/rust#152366 (Add try_shrink_to and try_shrink_to_fit to Vec) - rust-lang/rust#152640 (Add direct link to rustc-dev-guide in README) - rust-lang/rust#152963 (Revert "Stabilize `str_as_str`") - rust-lang/rust#152984 (Remove redundant call to `check_codegen_attributes_extra` in Inliner) - rust-lang/rust#152987 (Use `HashStable` derive in more places)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#152946 made a change to the logic for this attribute that the test should have flagged as problematic -- but the test only checked
Box, not&mut, and those have independent code paths. So extend the test to also cover&mut.@b-naber would be nice if you could confirm that the added tests do fail with your PR.