Skip to content

Migrate 11 tests from tests/ui/issues to specific directories#152966

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
raushan728:reorganize-ui-issues-1
Mar 3, 2026
Merged

Migrate 11 tests from tests/ui/issues to specific directories#152966
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
raushan728:reorganize-ui-issues-1

Conversation

@raushan728
Copy link
Contributor

Moved 11 regression tests from tests/ui/issues to their relevant subdirectories (imports, pattern, lint, and typeck).

  • Added standard issue tracking comments at the top of each file.
  • Relocated associated aux-build files.
  • Ran ./x.py test --bless successfully.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2026

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 15 candidates

@raushan728
Copy link
Contributor Author

Quick question: I moved the aux-build files into local auxiliary/ folders (e.g., tests/ui/imports/auxiliary/). Is this the standard way to organize them? Let me know if I should change it.

@rust-log-analyzer

This comment has been minimized.

@raushan728 raushan728 force-pushed the reorganize-ui-issues-1 branch from d94ebff to b88534d Compare February 22, 2026 11:01
@rust-log-analyzer

This comment has been minimized.

@raushan728
Copy link
Contributor Author

hi @Kivooeo and @Teapot4195 could you plz take a quick look and let me know if this organizational approach is what you have in mind?

@Kivooeo Kivooeo closed this Feb 22, 2026
@Kivooeo Kivooeo reopened this Feb 22, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2026
@Kivooeo Kivooeo assigned Kivooeo and unassigned fee1-dead Feb 23, 2026
@Kivooeo
Copy link
Member

Kivooeo commented Feb 24, 2026

For the next time please follow this workflow #149411 (comment)

@@ -0,0 +1,15 @@
// issue: rust-lang/rust#12612
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what I'll ask to fix is links. Can you replace all of this with actual links to issues

< https://github.com/rust-lang/rust/issues/number >

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Kivooeo
Copy link
Member

Kivooeo commented Feb 24, 2026

  • Ran ./x.py test --bless successfully.

why was --bless passed here?

@raushan728
Copy link
Contributor Author

  • Ran ./x.py test --bless successfully.

why was --bless passed here?

i ran --bless because the test files were renamed (e.g., from issue-11224.rs to a descriptive name) since the filename is printed in the compiler's diagnostic output the .stderr files needed to be regenerated to reflect the new file paths

@raushan728
Copy link
Contributor Author

hi @Kivooeo

I will make sure to separate the pure git mv operations into their own commit before modifying the contents

and i updated issues number with there actual link. plz take a look

@Kivooeo
Copy link
Member

Kivooeo commented Mar 2, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 2, 2026

📌 Commit b0d90ae has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026
… r=Kivooeo

Migrate 11 tests from tests/ui/issues to specific directories

Moved 11 regression tests from `tests/ui/issues` to their relevant subdirectories (`imports`, `pattern`, `lint`, and `typeck`).

* Added standard issue tracking comments at the top of each file.
* Relocated associated `aux-build` files.
* Ran `./x.py test --bless` successfully.
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #151864 (Implement AST -> HIR generics propagation in delegation)
 - #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
 - #153227 (Don’t report missing fields in struct exprs with syntax errors.)
 - #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
 - #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
 - #153034 (Remove unhelpful hint from trivial bound errors)
 - #153221 (Add release notes for 1.94.0)
 - #153297 (Update the name of the Hermit operating system)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
… r=Kivooeo

Migrate 11 tests from tests/ui/issues to specific directories

Moved 11 regression tests from `tests/ui/issues` to their relevant subdirectories (`imports`, `pattern`, `lint`, and `typeck`).

* Added standard issue tracking comments at the top of each file.
* Relocated associated `aux-build` files.
* Ran `./x.py test --bless` successfully.
rust-bors bot pushed a commit that referenced this pull request Mar 3, 2026
…uwer

Rollup of 12 pull requests

Successful merges:

 - #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
 - #153227 (Don’t report missing fields in struct exprs with syntax errors.)
 - #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
 - #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
 - #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
 - #153034 (Remove unhelpful hint from trivial bound errors)
 - #153152 (Migration of LintDiagnostic - part 5)
 - #153177 (disable the ptr_fragment_in_final test on s390x)
 - #153221 (Add release notes for 1.94.0)
 - #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
 - #153297 (Update the name of the Hermit operating system)
 - #153309 (Cleanup of c-variadic link test)
@rust-bors rust-bors bot merged commit e77eff6 into rust-lang:main Mar 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 3, 2026
rust-timer added a commit that referenced this pull request Mar 3, 2026
Rollup merge of #152966 - raushan728:reorganize-ui-issues-1, r=Kivooeo

Migrate 11 tests from tests/ui/issues to specific directories

Moved 11 regression tests from `tests/ui/issues` to their relevant subdirectories (`imports`, `pattern`, `lint`, and `typeck`).

* Added standard issue tracking comments at the top of each file.
* Relocated associated `aux-build` files.
* Ran `./x.py test --bless` successfully.
@raushan728 raushan728 deleted the reorganize-ui-issues-1 branch March 3, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants