Skip to content

WF check normalized assoc types when considering builtin object bound candidates#152923

Draft
ShoyuVanilla wants to merge 1 commit intorust-lang:mainfrom
ShoyuVanilla:builtin-object-proj-wf
Draft

WF check normalized assoc types when considering builtin object bound candidates#152923
ShoyuVanilla wants to merge 1 commit intorust-lang:mainfrom
ShoyuVanilla:builtin-object-proj-wf

Conversation

@ShoyuVanilla
Copy link
Member

@ShoyuVanilla ShoyuVanilla commented Feb 20, 2026

cc #152489

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 20, 2026
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Feb 20, 2026

Gonna try crater with the old solver changes first.
@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 20, 2026
@bors
Auto merge of #152923 - ShoyuVanilla:builtin-object-proj-wf, r=<try>
9ee38f2 
WF check normalized assoc types when considerting builtin object boun…
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 20, 2026
@ShoyuVanilla ShoyuVanilla changed the title WF check normalized assoc types when considerting builtin object boun… WF check normalized assoc types when considerting builtin object bound candidates Feb 20, 2026
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Feb 20, 2026

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Feb 20, 2026

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Feb 20, 2026

It seems crater doesn't wait for the try build to complete, unlike the timer 😅

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

☀️ Try build successful (CI)
Build commit: 9ee38f2 (9ee38f26dcdf48972651044088bfa67eb6edcd2f, parent: 59fd4ef94daa991e6797b5aa6127e824f3067def)

@rust-timer

This comment has been minimized.

Sign in to view
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Feb 20, 2026

@craterbot check

@craterbot
Copy link
Collaborator

craterbot commented Feb 20, 2026

👌 Experiment pr-152923 created and queued.
🤖 Automatically detected try build 9ee38f2
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Feb 20, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Feb 20, 2026

Finished benchmarking commit (9ee38f2): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.8% [-0.8%, -0.8%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -3.3% [-3.3%, -3.3%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -3.3% [-3.3%, -3.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 481.762s -> 482.964s (0.25%)
Artifact size: 397.93 MiB -> 397.87 MiB (-0.02%)

@craterbot
Copy link
Collaborator

craterbot commented Feb 22, 2026

🚧 Experiment pr-152923 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@ShoyuVanilla ShoyuVanilla changed the title WF check normalized assoc types when considerting builtin object bound candidates WF check normalized assoc types when considering builtin object bound candidates Feb 23, 2026
@craterbot
Copy link
Collaborator

craterbot commented Feb 24, 2026

🎉 Experiment pr-152923 is completed!
📊 321 regressed and 1 fixed (821749 total)
📊 2505 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-152923/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 24, 2026
@ShoyuVanilla
Copy link
Member Author

ShoyuVanilla commented Feb 24, 2026 •
edited
Loading

Maybe I'm normalizing and wf checking too much. Perhaps I should just check the existential project bound from the relevant trait id of the candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShoyuVanilla @rust-timer @craterbot @rustbot