Skip to content

[Experiment] Uses SsaLocals and MiRPatch to simplify SimplifyComparisonIntegral #151113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
dianqk wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[Experiment] Uses SsaLocals and MiRPatch to simplify SimplifyComparisonIntegral #151113

dianqk wants to merge 7 commits into from
+402 −267

Conversation

@dianqk
Copy link
Member

@dianqk dianqk commented Jan 14, 2026

I haven't addressed how to remove the pass, but it can be simplified.

r? ghost

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 14, 2026
@dianqk
Copy link
Member Author

dianqk commented Jan 14, 2026

@bors try parent=f57eac1bf98cb5d578e3364b64365ec398c137df @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of #151113 - dianqk:if-cmp-mirpatch, r=<try>
113015b 
[Experiment] Uses SsaLocals and MiRPatch to simplify SimplifyComparisonIntegral
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 14, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 14, 2026

☀️ Try build successful (CI)
Build commit: 113015b (113015b78f962411be16853e0a544b42aadcb378, parent: f57eac1bf98cb5d578e3364b64365ec398c137df)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 14, 2026

Finished benchmarking commit (113015b): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.4% [0.2%, 1.3%] 6
Regressions ❌
(secondary)		 0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)		 -1.3% [-1.8%, -0.8%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.0% [-1.8%, 1.3%] 8

Max RSS (memory usage)

Results (primary -0.5%, secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 3.1% [2.4%, 4.2%] 3
Regressions ❌
(secondary)		 0.5% [0.5%, 0.5%] 1
Improvements ✅
(primary)		 -3.1% [-5.1%, -1.9%] 4
Improvements ✅
(secondary)		 -1.3% [-2.6%, -0.8%] 4
All ❌✅ (primary) -0.5% [-5.1%, 4.2%] 7

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 0.0% [0.0%, 0.2%] 9
Regressions ❌
(secondary)		 0.1% [0.0%, 0.2%] 2
Improvements ✅
(primary)		 -0.1% [-1.1%, -0.0%] 13
Improvements ✅
(secondary)		 -0.0% [-0.1%, -0.0%] 2
All ❌✅ (primary) -0.0% [-1.1%, 0.2%] 22

Bootstrap: 473.812s -> 474.036s (0.05%)
Artifact size: 391.34 MiB -> 391.32 MiB (-0.00%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dianqk @rust-timer @rustbot