Feature-gate mut ref patterns in struct pattern field shorthand
#151102
+20
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use |
Contributor
|
@bors try |
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…ate, r=<try> Feature-gate `mut ref` patterns in struct pattern field shorthand
This comment has been minimized.
This comment has been minimized.
Contributor
Member
|
@craterbot check |
Collaborator
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue for
mut_ref(and other parts of Match Ergonomics 2024): #123076#123080 introduced
mut ref1 patterns (for by-reference bindings where the binding itself is mutable), feature-gated behind themut_reffeature, except for in struct pattern shorthand, where the feature gating was missing. Thus,mut refpatterns in struct pattern shorthand has been unintentionally stable for ~18 months (since 1.79.0 (compiler explorer)).This PR adds feature-gating for
mut refpatterns in struct pattern shorthand. Since this is reverting an accidental stabilization, this probably needs a crater run and a T-lang FCP?Some alternative possibilities:
feature(mut_ref)is stabilized)feature(mut_ref)CC #123080 (comment)
CC @Nadrieril
Footnotes
everything in this description also applies analogously to
mut ref mutpatterns. ↩