Skip to content

Improve code suggestion for incorrect macro_rules! usage #150988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
chenyukang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve code suggestion for incorrect macro_rules! usage #150988

chenyukang wants to merge 1 commit into from
+94 −29

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Jan 12, 2026 •
edited by rustbot
Loading

Fixes #150899

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2026

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

chenyukang
chenyukang commented Jan 12, 2026
View reviewed changes
tests/ui/macros/issue-118786.stderr
help: to define a macro, remove the parentheses around the macro name
|
LL - make_macro!((meow));
LL + make_macro!({meow});
Copy link
Member Author

@chenyukang chenyukang Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is a improvement, I added run-rustfix

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang
Copy link
Member Author

chenyukang commented Jan 12, 2026

@bors try jobs=x86_64-gnu-tools

rust-bors bot added a commit that referenced this pull request Jan 12, 2026
@rust-bors
Auto merge of #150988 - chenyukang:yukang-fix-150899-macro-rules, r=<…
1e976b1 
…try>

Improve code suggestion for incorrect macro_rules! usage

try-job: x86_64-gnu-tools
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 12, 2026

☀️ Try build successful (CI)
Build commit: 1e976b1 (1e976b1323de0dab3e87fb93cb0f6a3bf75847bd, parent: 840245e91b90f22adf9f26d0a0cd98c2416cdef3)

@chenyukang
Copy link
Member Author

chenyukang commented Jan 12, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

............................................       (144/144)

======== tests/rustdoc-gui/notable-trait.goml ========

[ERROR] line 255: expected 0 elements, found 1: for command `assert-count: ("//*[@class='tooltip popover']", 0)`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

seems the test is not stable, retry it succeed.

@chenyukang chenyukang force-pushed the yukang-fix-150899-macro-rules branch from 47f0180 to 16bc545 Compare January 12, 2026 11:01
@jieyouxu jieyouxu mentioned this pull request Jan 12, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SparrowLii SparrowLii

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better help text for incorrect macro_rules! usage

4 participants

@chenyukang @rustbot @rust-log-analyzer @SparrowLii