Skip to content

Port symbol mangler attrs #150949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Bryntet wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Port symbol mangler attrs #150949

Bryntet wants to merge 1 commit into from
+73 −8

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Jan 11, 2026 •
edited by rustbot
Loading

Tracking issue: #131229

@JonathanBrouwer could you run perf on this?

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 11, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 11, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jan 11, 2026
@rust-bors
Auto merge of #150949 - Bryntet:port_symbol_mangler_attrs, r=<try>
3162956 
Port symbol mangler attrs
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☀️ Try build successful (CI)
Build commit: 3162956 (3162956ac6c60e4ef7d9ae98b1319ef2d1e08ec6, parent: 9bc8b40bc314b74e1d5e5ab21a0df39c55a34806)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 11, 2026

Finished benchmarking commit (3162956): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.2% [-0.4%, -0.0%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.6% [0.6%, 0.6%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.8% [-3.5%, -2.0%] 2
All ❌✅ (primary) - - 0

Cycles

Results (secondary -3.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -10.2% [-10.2%, -10.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.122s -> 472.718s (-0.09%)
Artifact size: 391.33 MiB -> 391.30 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 11, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 11, 2026

☔ The latest upstream changes (presumably #150957) made this pull request unmergeable. Please resolve the merge conflicts.

@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from beed1d6 to aafb475 Compare January 12, 2026 17:13
@Bryntet Bryntet force-pushed the port_symbol_mangler_attrs branch from aafb475 to 0e0bbee Compare January 12, 2026 17:21
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 12, 2026
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bryntet @JonathanBrouwer @rust-timer @rustbot