std: sys: fs: uefi: Implement File::flush #150862

Ayush1325 · 2026-01-09T06:56:07Z

Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync.

@rustbot label +O-UEFI

rustbot · 2026-01-09T06:56:12Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

the8472 · 2026-01-09T07:13:49Z

library/std/src/sys/fs/uefi.rs

    pub fn flush(&self) -> io::Result<()> {
-        unsupported()
+        self.0.flush()
    }


The Write::flush method should be a noop for Files. It's only meant to flush buffered writers to the OS, since files are unbuffered there's nothing to do.

I have made it a noop and added a comment for the same. However, while it is a noop on unix and windows, other platforms like motor, solid, etc seem to call normal file flush on it.

I don't know whether those platforms do anything special or it just wasn't caught during review.

CC @lasiotus @kawadakk in case the platforms need fixing.

Thanks for the ping!

Re: flushing a file on Motor OS: the story is a bit complicated: while at the moment the call is a noop, it won't be in the future, as Motor OS is moving towards a fully asynchronous I/O (at the moment file I/O is synchronous) with in-process async runtime, so flushing a file will not stay a noop. The good news is that the call is already plumbed through to Motor OS runtime, so no changes to Rust std are expected.

- Make flush a noop since it is only for buffered writers. - Also forward fsync to datasync. UEFI does not have anything separate for metadata sync. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

the8472 · 2026-01-10T01:57:46Z

@bors r+

rust-bors · 2026-01-10T01:57:50Z

📌 Commit f6f901f has been approved by the8472

It is now in the queue for this repository.

@rustbot

std: sys: fs: uefi: Implement File::flush - Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync. @rustbot label +O-UEFI

@rustbot

std: sys: fs: uefi: Implement File::flush - Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync. @rustbot label +O-UEFI

@rustbot

std: sys: fs: uefi: Implement File::flush - Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync. @rustbot label +O-UEFI

@rustbot

std: sys: fs: uefi: Implement File::flush - Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync. @rustbot label +O-UEFI

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150786 (mGCA: Support array expression as direct const arguments) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) r? @ghost

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

@rustbot

Rollup merge of #150862 - uefi-fs-flush, r=the8472 std: sys: fs: uefi: Implement File::flush - Also forward fsync and datasync to flush. UEFI does not have anything separate for metadata sync. @rustbot label +O-UEFI

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

rustbot assigned Mark-Simulacrum Jan 9, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 9, 2026

rustbot added the O-UEFI UEFI label Jan 9, 2026

Ayush1325 mentioned this pull request Jan 9, 2026

Tracking Issue for uefi-std #100499

Open

the8472 reviewed Jan 9, 2026

View reviewed changes

std: sys: fs: uefi: Implement File::{flush, *sync}

f6f901f

- Make flush a noop since it is only for buffered writers. - Also forward fsync to datasync. UEFI does not have anything separate for metadata sync. Signed-off-by: Ayush Singh <ayush@beagleboard.org>

Ayush1325 force-pushed the uefi-fs-flush branch from b83eb4e to f6f901f Compare January 9, 2026 17:07

Ayush1325 requested a review from the8472 January 9, 2026 17:07

rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 10, 2026

rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026

Zalathar mentioned this pull request Jan 10, 2026

Rollup of 15 pull requests #150914

Closed

JonathanBrouwer mentioned this pull request Jan 10, 2026

Rollup of 14 pull requests #150924

Closed

Zalathar mentioned this pull request Jan 11, 2026

[EXPERIMENT] Rollup of 15 pull requests #150948

Closed

Zalathar mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150952

Closed

matthiaskrgr mentioned this pull request Jan 11, 2026

Rollup of 14 pull requests #150957

Merged

rust-bors bot merged commit 98270a9 into rust-lang:main Jan 11, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 11, 2026

Ayush1325 deleted the uefi-fs-flush branch January 11, 2026 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

std: sys: fs: uefi: Implement File::flush #150862

std: sys: fs: uefi: Implement File::flush #150862

Ayush1325 commented Jan 9, 2026

Uh oh!

rustbot commented Jan 9, 2026

Uh oh!

the8472 Jan 9, 2026

Uh oh!

Ayush1325 Jan 9, 2026

Uh oh!

the8472 Jan 10, 2026

Uh oh!

lasiotus Jan 10, 2026

Uh oh!

the8472 commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

std: sys: fs: uefi: Implement File::flush #150862

std: sys: fs: uefi: Implement File::flush #150862

Conversation

Ayush1325 commented Jan 9, 2026

Uh oh!

rustbot commented Jan 9, 2026

Uh oh!

the8472 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Ayush1325 Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

lasiotus Jan 10, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 commented Jan 10, 2026

Uh oh!

rust-bors bot commented Jan 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants