Implement the "linux_pidfd" feature for FreeBSD #150814
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have two concerns with this PR:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
☔ The latest upstream changes (presumably #151107) made this pull request unmergeable. Please resolve the merge conflicts. |
FreeBSD's procdesc(4)[^1] is a file-descriptor-oriented interface to process signalling and control. It's a race-free replacement for fork() and kill(), and it's compatible with capsicum[^2]. Its drawbacks are that there isn't yet a way to use it with posix_spawn, and there's no capsicum-compatible way to use it with wait(). But it's still sufficient for the linux_pidfd feature. [^1]: https://man.freebsd.org/cgi/man.cgi?query=procdesc [^2]: https://man.freebsd.org/cgi/man.cgi?query=capsicum
4b4aa45 to
87f7a97
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD's procdesc(4)1 is a file-descriptor-oriented interface to process signalling and control. It's a race-free replacement for fork() and kill(), and it's compatible with capsicum2.
Its drawbacks are that there isn't yet a way to use it with posix_spawn, and there's no capsicum-compatible way to use it with wait(). But it's still sufficient for the linux_pidfd feature.
r? @the8472
Issue #82971
Footnotes
https://man.freebsd.org/cgi/man.cgi?query=procdesc ↩
https://man.freebsd.org/cgi/man.cgi?query=capsicum ↩